Add per-provider enrich with userinfo endpoint setting#1445
Conversation
Signed-off-by: s3n-w6i <37022952+s3n-w6i@users.noreply.github.com>
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Nice PR, thanks.
- Backward compatibility 👍
- No migration needed 👍 because the value is stored in app config as a new row with the key
provider-N-enrichLoginIdTokenWithUserinfofor each provider
Signed-off-by: s3n-w6i <37022952+s3n-w6i@users.noreply.github.com>
testGetProvidersWithSettings: Since all boolean options are set to true by default, also set enrichLoginIdTokenWithUserinfo to true testSetSettings: Add missing enrichLoginIdTokenWithUserinfo field Signed-off-by: s3n-w6i <37022952+s3n-w6i@users.noreply.github.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
2 participants
What
This change introduces a checkbox into the provider settings that allows enabling the existing
enrich_login_id_token_with_userinfooption on a per-provider basis.To be backwards compatible, if the global
enrich_login_id_token_with_userinfois set to true, the userinfo endpoint is still fetched for all providers, regardless of their per-provider setting.Why
Open questions
enrichLoginIdTokenWithUserinfoon the provider's settings object. This does not require any database schema changes, right?