Skip to content

centralize some XML helper functions#1624

Merged
phyy-nx merged 2 commits into
mainfrom
1623-dev_tools-xml-tag-parsing
May 27, 2026
Merged

centralize some XML helper functions#1624
phyy-nx merged 2 commits into
mainfrom
1623-dev_tools-xml-tag-parsing

Conversation

@woutdenolf

@woutdenolf woutdenolf commented Mar 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #1623

I checked that this does not introduce regressions

diff -ru --exclude='*.js' build/manual/build/html keep/manual/build/html

@woutdenolf woutdenolf linked an issue Mar 15, 2026 that may be closed by this pull request
dev_tools: XML tag parsing #1623
Closed
woutdenolf
woutdenolf commented Mar 15, 2026
View reviewed changes
Comment thread dev_tools/utils/xml_utils.py
@woutdenolf woutdenolf requested a review from PeterC-DLS March 15, 2026 18:50
@woutdenolf woutdenolf force-pushed the 1623-dev_tools-xml-tag-parsing branch from 96d7ec8 to 8881640 Compare March 15, 2026 18:52
PeterC-DLS
PeterC-DLS reviewed Mar 16, 2026
View reviewed changes
Comment thread dev_tools/utils/nxdl_utils.py Outdated
PeterC-DLS
PeterC-DLS approved these changes Mar 16, 2026
View reviewed changes

@PeterC-DLS PeterC-DLS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM subject to Sandor's response

@lukaspie

lukaspie commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

@woutdenolf thanks for this effort.

We are currently using functions from these dev_tools directly in some of our tools in https://github.com/FAIRmat-NFDI/pynxtools. That's also the reason why some function mangle hdf5 and xml logic.

We are eventually planning to move away from this (and then there could be further cleanup done here), but that would not be possible right away. Therefore, I would like to check that these tools still work with your changes from this branch. Could you hold of with merging while I test this? Thanks!

@woutdenolf woutdenolf mentioned this pull request Mar 18, 2026
Merged
@woutdenolf woutdenolf force-pushed the 1623-dev_tools-xml-tag-parsing branch from e30df78 to ccc5c8c Compare April 29, 2026 16:39
@woutdenolf

woutdenolf commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

Squash and rebase after #1613.

@lukaspie

lukaspie commented May 21, 2026

Copy link
Copy Markdown
Contributor

@woutdenolf thanks for this effort.

We are currently using functions from these dev_tools directly in some of our tools in FAIRmat-NFDI/pynxtools. That's also the reason why some function mangle hdf5 and xml logic.

We are eventually planning to move away from this (and then there could be further cleanup done here), but that would not be possible right away. Therefore, I would like to check that these tools still work with your changes from this branch. Could you hold of with merging while I test this? Thanks!

@woutdenolf we removed almost all dependencies on dev_tools, so okay to go ahead with this from our side.

@phyy-nx phyy-nx merged commit 9a4a123 into main May 27, 2026
3 checks passed
@phyy-nx phyy-nx deleted the 1623-dev_tools-xml-tag-parsing branch May 27, 2026 15:32
mretegan pushed a commit to XraySpectroscopy/nexus_definitions that referenced this pull request Jun 5, 2026
@woutdenolf @mretegan
centralize some XML helper functions (nexusformat#1624)
21470a1 
* centralize some XML helper functions

* clarify OSError handling when reading XML files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeterC-DLS PeterC-DLS PeterC-DLS approved these changes

@sanbrock sanbrock sanbrock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dev_tools: XML tag parsing

5 participants

@woutdenolf @lukaspie @PeterC-DLS @sanbrock @phyy-nx