Fix spurious language field migrations and add USER_LANGUAGES#1247
Merged
Fix spurious language field migrations and add USER_LANGUAGES#1247
Conversation
Contributor
Author
|
Tests fail because okfde/django-filingcabinet#101 has to be merged first. |
noeddl
force-pushed
the
noeddl/user-languages
branch
2 times, most recently
from
8e08e65 to
b0a3c28
Compare
n0ctua
approved these changes
Apr 22, 2026
Contributor
n0ctua
left a comment
n0ctua
left a comment
There was a problem hiding this comment.
Looks good to me. I just added some questions and possible pitfalls in the comments you might want to check out.
Replace inline use of settings.LANGUAGE_CODE and settings.LANGUAGES with callables so changes to these settings no longer trigger new migrations.
noeddl
force-pushed
the
noeddl/user-languages
branch
from
b0a3c28 to
e69d2e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
settings.LANGUAGE_CODEandsettings.LANGUAGESwith callables so changes to these settings no longer trigger new migrations (see also 🐛 Fix spurious language field migrations across projects django-filingcabinet#101).USER_LANGUAGESto allow for defining a separate set of languages to be used in user dialogues, e.g. to excludede-lsfrom user language choice in the account settings.