Skip to content

prevent duplicate items in search registry#1248

Merged
krmax44 merged 2 commits intomainfrom
krmax44/search-registry
Apr 20, 2026
Merged

prevent duplicate items in search registry#1248
krmax44 merged 2 commits intomainfrom
krmax44/search-registry

Conversation

@krmax44
Copy link
Copy Markdown
Member

@krmax44 krmax44 commented Apr 16, 2026

  • ➕ add django-stubs-ext
  • 🐛 prevent searches from being registered multiple times

@stefanw
Copy link
Copy Markdown
Member

stefanw commented Apr 16, 2026

This needs changes in all call sites, I'd go for an optional name keyword parameter in search_registry.register. So far only CMS searches are duplicated (due to the way they are registered), so only those need to be deduplicated.

@krmax44 krmax44 force-pushed the krmax44/search-registry branch from 177abc3 to a04c5a8 Compare April 20, 2026 09:25
@krmax44 krmax44 force-pushed the krmax44/search-registry branch from a04c5a8 to 454c91f Compare April 20, 2026 09:28
@krmax44 krmax44 merged commit 66cb34e into main Apr 20, 2026
4 checks passed
@krmax44 krmax44 deleted the krmax44/search-registry branch April 20, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants