Update models docstrings to follow proper RST conventions#583
Open
ormsbee wants to merge 1 commit into
Open
Conversation
This fixes a lot of formatting, including things like improperly specified lists, Markdown formatting conventions, and many missing module and class references. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
@sarina, @kdmccormick: This PR is ready for review. I had to make a few minor edits after Claude went through it, and I modified some comments to remove outdated TODOs. Otherwise, it's all just reformatting as described in the prompt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reformats a lot of our docstrings to follow RST practices properly, like real links to classes and models, fixing some Markdown-isms, reformatting broken definition lists, etc. The thing that makes me twitch the most is reformatting large block-comments over variable declarations to be docstring-like comments under them.
This doesn't fix everything, but it rehabilitates the docs to a place that is much better than where we started. This did not add any new content to the docs—it's just reformatting and some rephrasing on my part as part of some manual edits. I've deleted a few outdated TODO items, but I've otherwise refrained from trying to do any additional editing to the docstrings for now, in the hopes of landing this more easily.
To test locally, run
make docsat the root. You may need to install therequirements/doc.txtrequirements.The Claude prompt: