Compiler.run(): finalCallback sets compiler.idle = true twice #20617
Unanswered
siddhiguptas
asked this question in
Q&A
Replies: 2 comments
-
|
You will be ignored in future if you will use AI to generate the issue and will ignore our issue templates |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Hey @siddhiguptas, Dependency resolution and plugin configuration in Webpack can get messy quickly. Checking if a recent loader version update (or Babel mismatch) caused a breaking change might be the fastest way to isolate the issue. Let us know if you find the root configuration bug! Let me know if you make any progress or if you need another fresh set of eyes on it! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Fix: Duplicate
compiler.idleAssignment inCompiler.run()Overview
This change fixes a small state-management issue in
lib/Compiler.jsinside theCompiler.run()method.Within the
finalCallback, the compiler lifecycle setsthis.idle = truetwice consecutively around a call tothis.cache.beginIdle(). The second assignment is redundant and does not contribute to the intended state transition.Removing the duplicate assignment improves clarity of the compiler lifecycle and avoids unnecessary duplicate state writes.
Location
File:
lib/Compiler.jsMethod:
Compiler.run()Section:
finalCallbackCurrent Code (Simplified)
Beta Was this translation helpful? Give feedback.
All reactions