Skip to content

Make idol_result return a Load-able type#660

Open
mkeeter wants to merge 2 commits into
mkeeter/hiffy-call-unpackfrom
mkeeter/loading-idol-result
Open

Make idol_result return a Load-able type#660
mkeeter wants to merge 2 commits into
mkeeter/hiffy-call-unpackfrom
mkeeter/loading-idol-result

Conversation

@mkeeter
Copy link
Copy Markdown
Contributor

@mkeeter mkeeter commented May 12, 2026 •
edited
Loading

(staged on #664)

This is a small cleanup to automatically load a value returned from idol_result (along the same lines as #631)

@mkeeter mkeeter requested a review from labbott May 12, 2026 21:42
@mkeeter mkeeter mentioned this pull request May 12, 2026
Open
@mkeeter mkeeter force-pushed the mkeeter/hiffy-call-unpack branch from 34d42b2 to 9899a0c Compare May 13, 2026 21:41
@mkeeter mkeeter force-pushed the mkeeter/loading-idol-result branch from e0a515b to 2dea381 Compare May 13, 2026 21:41
@mkeeter mkeeter force-pushed the mkeeter/hiffy-call-unpack branch from 9899a0c to 76fc855 Compare May 14, 2026 16:20
@mkeeter mkeeter force-pushed the mkeeter/loading-idol-result branch 2 times, most recently from 861ffd1 to c3de5fa Compare May 14, 2026 16:48
@mkeeter mkeeter force-pushed the mkeeter/hiffy-call-unpack branch from 76fc855 to 7c9ee88 Compare May 14, 2026 16:48
@mkeeter mkeeter force-pushed the mkeeter/loading-idol-result branch from c3de5fa to e66628c Compare May 14, 2026 19:08
@mkeeter mkeeter force-pushed the mkeeter/hiffy-call-unpack branch from 1aaac5b to a98eb7d Compare May 18, 2026 19:30
@mkeeter mkeeter force-pushed the mkeeter/loading-idol-result branch 2 times, most recently from a9801cb to 61239ac Compare May 18, 2026 19:53
@mkeeter mkeeter force-pushed the mkeeter/hiffy-call-unpack branch from a98eb7d to 3aa54d7 Compare May 18, 2026 19:53
@mkeeter
Copy link
Copy Markdown
Contributor Author

mkeeter commented May 18, 2026 •
edited
Loading

vpd --list works, although I can't test the locking commands locally.

matt@niles ~ () $ pfexec ./humility -tgimlet-d vpd -r --list
humility: attached to 0483:3754:000D00344741500820383733 via ST-Link V3
ID  C P  MUX ADDR DEVICE        DESCRIPTION               LOCKED
 0  2 F  1:1 0x50 at24csw080    U.2 Sharkfin A VPD        unlocked
 |
 +--> [("FRU0",[("BARC",["0XV2:913-0000021:002:BRM04230373"])])]

 1  2 F  1:2 0x50 at24csw080    U.2 Sharkfin B VPD        unlocked
 |
 +--> [("FRU0",[("BARC",["0XV2:913-0000021:002:BRM04230710"])])]

 2  2 F  1:3 0x50 at24csw080    U.2 Sharkfin C VPD        unlocked
 |
 +--> [("FRU0",[("BARC",["0XV2:913-0000021:002:BRM04230183"])])]

 3  2 F  1:4 0x50 at24csw080    U.2 Sharkfin D VPD        unlocked
 |
 +--> [("FRU0",[("BARC",["0XV2:913-0000021:002:BRM04230487"])])]

 4  2 F  2:1 0x50 at24csw080    U.2 Sharkfin E VPD        unlocked
 |
 +--> [("FRU0",[("BARC",["0XV2:913-0000021:002:BRM04230210"])])]

 5  2 F  2:2 0x50 at24csw080    U.2 Sharkfin F VPD        unlocked
 |
 +--> [("FRU0",[("BARC",["0XV2:913-0000021:002:BRM04230374"])])]

 6  2 F  2:3 0x50 at24csw080    U.2 Sharkfin G VPD        unlocked
 |
 +--> [("FRU0",[("BARC",["0XV2:913-0000021:002:BRM04230604"])])]

 7  2 F  2:4 0x50 at24csw080    U.2 Sharkfin H VPD        unlocked
 |
 +--> [("FRU0",[("BARC",["0XV2:913-0000021:002:BRM04230063"])])]

 8  2 F  3:1 0x50 at24csw080    U.2 Sharkfin I VPD        unlocked
 |
 +--> <bad header: HeaderCorrupt { stored_checksum: 0, computed_checksum: ffffffff }>

 9  2 F  3:2 0x50 at24csw080    U.2 Sharkfin J VPD        unlocked
 |
 +--> [("FRU0",[("BARC",["0XV2:913-0000021:002:BRM04230376"])])]

10  2 F  3:4 0x50 at24csw080    Gimlet VPD                unlocked
 |
 +--> [("FRU0",[("BARC",["0XV2:913-0000019:011:BRM23230022"]),("MAC0",[[168,64,37,4,6,199,8,0,8]])])]

11  2 B  1:3 0x50 at24csw080    Fan VPD                   unlocked
 |
 +--> [("FRU0",[("BARC",["0XV2:991-0000084:004:BRM11230023"]),("SASY",[("BARC",["0XV2:913-0000022:002:BRM04230086"]),("BARC",["0XV2:991-0000094:001:BRM04230260"]),("BARC",["0XV2:991-0000094:001:BRM04230256"]),("BARC",["0XV2:991-0000094:001:BRM04230253"])])])]

@mkeeter mkeeter force-pushed the mkeeter/loading-idol-result branch from 61239ac to 1fe703a Compare May 18, 2026 20:21
@mkeeter mkeeter force-pushed the mkeeter/loading-idol-result branch 3 times, most recently from 5e1dc9e to 4a5d1b2 Compare May 18, 2026 20:50
@mkeeter mkeeter force-pushed the mkeeter/loading-idol-result branch from 4a5d1b2 to a25af4c Compare May 18, 2026 20:53
@mkeeter
Copy link
Copy Markdown
Contributor Author

mkeeter commented May 18, 2026

humility sbrmi also works:

matt@niles ~ () $ pfexec ./humility -tgimlet-d sbrmi -m -t0
humility: attached to 0483:3754:000D00344741500820383733 via ST-Link V3
MCA registers for thread 0x0 (0):

    MCA_CTL(0)     0x0001002e00ffffff
    MCA_STATUS(0)  0x0000000000000000
    MCA_ADDR(0)    0x0000000000000000
    MCA_MISC(0)    0xd010000000000000
    MCA_CONFIG(0)  0x00000007000001fd
                   |
                   +---> Interrupt Enable (IntEn)            = false
                         Deferred error type                 = 0x0
                         MCAX enable (McaxEn)                = true
                         MCA FRU text supported              = false
                         Address LSB in MCA_STATUS           = true
                         Deferred error status supported     = true
                         System fatal error event supported  = true
                         Deferred interrupt type supported   = true
                         Deferred error logging supported    = true
                         MCAX capable                        = true

    MCA_SYND(0)    0x0000000000000000
    MCA_IPID(0)    0x001000b000000000
                   |
                   +---> MCA bank type                       = 0x10
                         Instance ID (high)                  = 0x0
                         Hardware ID                         = 0xb0
                         Instance ID (low)                   = 0x0

    MCA_DESTAT(0)  0x0000000000000000
    MCA_DEADDR(0)  0x0000000000000000

    MCA_CTL(1)     0x000000000007ffff
    MCA_STATUS(1)  0x0000000000000000
    MCA_ADDR(1)    0x0000000000000000
    MCA_MISC(1)    0x0000000000000000
    MCA_CONFIG(1)  0x00000003000001f9
                   |
                   +---> Interrupt Enable (IntEn)            = false
                         Deferred error type                 = 0x0
                         MCAX enable (McaxEn)                = true
                         MCA FRU text supported              = false
                         Address LSB in MCA_STATUS           = true
                         Deferred error status supported     = true
                         System fatal error event supported  = true
                         Deferred interrupt type supported   = true
                         Deferred error logging supported    = false
                         MCAX capable                        = true

    MCA_SYND(1)    0x0000000000000000
    MCA_IPID(1)    0x000100b000000000
                   |
                   +---> MCA bank type                       = 0x1
                         Instance ID (high)                  = 0x0
                         Hardware ID                         = 0xb0
                         Instance ID (low)                   = 0x0

    MCA_DESTAT(1)  0x0000000000000000
    MCA_DEADDR(1)  0x0000000000000000

...etc
matt@niles ~ () $ pfexec ./humility -tgimlet-d sbrmi
humility: attached to 0483:3754:000D00344741500820383733 via ST-Link V3
 THR 0x0 0x1 0x2 0x3 0x4 0x5 0x6 0x7 0x8 0x9 0xa 0xb 0xc 0xd 0xe 0xf
0x00  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok
0x10  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok
0x20  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok
0x30  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok
0x40  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok
0x50  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok
0x60  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok
0x70  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok  ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@labbott labbott Awaiting requested review from labbott

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mkeeter