From db325bef74410db1f1535996b50b732b8bfbb165 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 12 Aug 2026 20:51:26 +0000 Subject: [PATCH] Trim panel-title whitespace expectations for PMM-15308 percona/pmm#5767 strips leading/trailing whitespace from 39 dashboard titles. The panel names asserted by the QA suites still carry the stray spaces, so they stop matching once that change lands. - MySQL Group Replication Summary: Applied/Sent/Rolled Back Transactions - HAProxy Instance Summary: Aborted Data Transfers - Nodes Overview (codeceptjs): eight leading-space panel names - MySQL User Details: drop the spacer panel whose title was a single space and is now empty, so it no longer has a name to match Signed-off-by: Claude --- codeceptjs-e2e/tests/pages/dashboardPage.js | 16 ++++++++-------- .../dashboards/mysql/haproxyInstanceSummary.ts | 2 +- .../mysql/mysqlGroupReplicationSummary.ts | 6 +++--- .../pages/dashboards/mysql/mysqlUserDetails.ts | 1 - 4 files changed, 12 insertions(+), 13 deletions(-) diff --git a/codeceptjs-e2e/tests/pages/dashboardPage.js b/codeceptjs-e2e/tests/pages/dashboardPage.js index cebe9e236..bda73ee97 100644 --- a/codeceptjs-e2e/tests/pages/dashboardPage.js +++ b/codeceptjs-e2e/tests/pages/dashboardPage.js @@ -1079,20 +1079,20 @@ module.exports = { 'Top 5 Swap Out (Writes)', 'Min Free Space Available', 'Top I/O Load', - ' Top Disk Latency', - ' Top Disk Operations', - ' Top Disk Bandwidth', - ' Top I/O Activity', + 'Top Disk Latency', + 'Top Disk Operations', + 'Top Disk Bandwidth', + 'Top I/O Activity', 'Top 5 Disk I/O Load', 'Disk I/O Load', 'Top 5 Disk Latency', - ' Disk Latency', + 'Disk Latency', 'Top 5 Disk Bandwidth', - ' Disk Bandwidth', + 'Disk Bandwidth', 'Top 5 I/O Activity', 'I/O Activity', - ' Top Receive Network Traffic', - ' Top Transmit Network Traffic', + 'Top Receive Network Traffic', + 'Top Transmit Network Traffic', 'Top Errors', 'Top Drop', 'Top Retransmission', diff --git a/e2e_tests/pages/dashboards/mysql/haproxyInstanceSummary.ts b/e2e_tests/pages/dashboards/mysql/haproxyInstanceSummary.ts index 42a94c64e..784a78b11 100644 --- a/e2e_tests/pages/dashboards/mysql/haproxyInstanceSummary.ts +++ b/e2e_tests/pages/dashboards/mysql/haproxyInstanceSummary.ts @@ -24,7 +24,7 @@ export default class HaproxyInstanceSummary implements DashboardInterface { { name: 'Session Limit', type: 'table' }, { name: 'Maximum Observed Sessions Rate', type: 'table' }, { name: 'Backend Data', type: 'timeSeries' }, - { name: 'Aborted Data Transfers ', type: 'timeSeries' }, + { name: 'Aborted Data Transfers', type: 'timeSeries' }, { name: 'Connection Errors', type: 'timeSeries' }, { name: 'Connection Establishment Attempts', type: 'timeSeries' }, { name: 'Connection Reuses', type: 'timeSeries' }, diff --git a/e2e_tests/pages/dashboards/mysql/mysqlGroupReplicationSummary.ts b/e2e_tests/pages/dashboards/mysql/mysqlGroupReplicationSummary.ts index 85c0b3a7c..adcd14252 100644 --- a/e2e_tests/pages/dashboards/mysql/mysqlGroupReplicationSummary.ts +++ b/e2e_tests/pages/dashboards/mysql/mysqlGroupReplicationSummary.ts @@ -14,10 +14,10 @@ export default class MysqlGroupReplicationSummary implements DashboardInterface { name: 'Transaction Time Inside the Local Queue', type: 'timeSeries' }, { name: 'Checked Transactions', type: 'timeSeries' }, { name: 'Transactions Row Validating', type: 'timeSeries' }, - { name: 'Applied Transactions ', type: 'timeSeries' }, - { name: 'Sent Transactions ', type: 'timeSeries' }, + { name: 'Applied Transactions', type: 'timeSeries' }, + { name: 'Sent Transactions', type: 'timeSeries' }, { name: 'Received Transactions Queue', type: 'timeSeries' }, - { name: 'Rolled Back Transactions ', type: 'timeSeries' }, + { name: 'Rolled Back Transactions', type: 'timeSeries' }, { name: 'Transactions in the Queue for Checking', type: 'timeSeries' }, { name: 'Detected Conflicts', type: 'timeSeries' }, ]; diff --git a/e2e_tests/pages/dashboards/mysql/mysqlUserDetails.ts b/e2e_tests/pages/dashboards/mysql/mysqlUserDetails.ts index cd6c95fb8..850991a77 100644 --- a/e2e_tests/pages/dashboards/mysql/mysqlUserDetails.ts +++ b/e2e_tests/pages/dashboards/mysql/mysqlUserDetails.ts @@ -4,7 +4,6 @@ import DashboardInterface from '@interfaces/dashboard'; export default class MySQLUserDetails implements DashboardInterface { url = 'graph/d/mysql-user/mysql-user-details'; metrics: GrafanaPanel[] = [ - { name: ' ', type: 'empty' }, { name: 'Active Users', type: 'stat' }, { name: 'Lost Connections', type: 'stat' }, { name: 'Denied Connections', type: 'stat' },