From 442053961e8099ae7873dcb2e2d836354a133d6e Mon Sep 17 00:00:00 2001 From: Arek Date: Wed, 11 Nov 2015 21:24:54 +0100 Subject: [PATCH] Add changeVolume API - 03-factory-angularPlayer.js Decrease code redundancy by shifting changeVolume function to API. This make change global volume variable possible: ```js angular.module('myApp') .controller('myCtrl', ['$scope', 'angularPlayer', function($scope, angularPlayer){ angularPlayer.changeVolume(25); }]); ``` --- src/03-factory-angularPlayer.js | 29 ++++++++++++----------------- 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/src/03-factory-angularPlayer.js b/src/03-factory-angularPlayer.js index 8fac400..28e2bb5 100644 --- a/src/03-factory-angularPlayer.js +++ b/src/03-factory-angularPlayer.js @@ -315,35 +315,30 @@ ngSoundManager.factory('angularPlayer', ['$rootScope', '$log', getVolume: function() { return volume; }, + changeVolume: function(newVolume) { + // chaning global variable too + volume = newVolume; + for(var i = 0; i < soundManager.soundIDs.length; i++) { + var mySound = soundManager.getSoundById(soundManager.soundIDs[i]); + mySound.setVolume(volume); + } + $rootScope.$broadcast('music:volume', volume); + }, adjustVolume: function(increase) { - var changeVolume = function(volume) { - for(var i = 0; i < soundManager.soundIDs.length; i++) { - var mySound = soundManager.getSoundById(soundManager.soundIDs[i]); - mySound.setVolume(volume); - } - $rootScope.$broadcast('music:volume', volume); - }; if(increase === true) { if(volume < 100) { volume = volume + 10; - changeVolume(volume); + this.changeVolume(volume); } } else { if(volume > 0) { volume = volume - 10; - changeVolume(volume); + this.changeVolume(volume); } } }, adjustVolumeSlider: function(value) { - var changeVolume = function(volume) { - for(var i = 0; i < soundManager.soundIDs.length; i++) { - var mySound = soundManager.getSoundById(soundManager.soundIDs[i]); - mySound.setVolume(volume); - } - $rootScope.$broadcast('music:volume', volume); - }; - changeVolume(value); + this.changeVolume(value); }, clearPlaylist: function(callback) { $log.debug('clear playlist');