libtsk: unable to build with gcc 15

[arnonuehm66]

Compiling with gcc version 15 fails.

typedef bool results in an error, because gcc 15 will default to -std=C23 , where C now has a boolean type.

A resolution might be using gcc -std=C17 or older.

[joachimmetz]

Is this the error you get?

...
In file included from crc.c:44:
crc.h:94:25: error: both 'unsigned' and '_Bool' in declaration specifiers
   94 | typedef unsigned        bool;
      |                         ^~~~
crc.h:94:1: warning: useless type name in empty declaration
   94 | typedef unsigned        bool;
      | ^~~~~~~
...
make[3]: *** [Makefile:477: crc.lo] Error 1
make[2]: *** [Makefile:569: all-recursive] Error 1
make[1]: *** [Makefile:445: all] Error 2
make: *** [Makefile:593: all-recursive] Error 1

gcc version 15.1.1 20250521 (Red Hat 15.1.1-2) (GCC)

[joachimmetz]

Possibly related: sleuthkit/sleuthkit#3356

[arnonuehm66]

More like this:

main.c:115:16: error: expected ';' before 'bool'
  115 | typedef integer bool;
      |                ^~~~~
      |                ;
main.c:115:1: warning: useless type name in empty declaration
  115 | typedef integer bool;
      | ^~~~~~~
make: *** [Makefile:13: skeleton_main_c] Error 1

It reads kind of "bool exists already" . Yours is more like "_Bool is already defined".

Edit: Changed error message from german to english.

[joachimmetz]

In which file? There is no main.c in pytsk/libtsk AFAIK.

grep -re 'typedef.*bool' .
./sleuthkit/tsk/base/crc.h:typedef unsigned        bool;
./sleuthkit/tsk/img/aff.c:typedef int bool;
./talloc/replace.h:typedef int bool;

[arnonuehm66]

Sorry but I had to recreate the error, because I'm on a different laptop.

Will paste the original later, if I'm back at my working computer.

Edit: Could recreate error on this laptop.

In file included from talloc/talloc.c:33:
talloc/replace.h:14:13: error: ‘bool’ cannot be defined via ‘typedef’
   14 | typedef int bool;
      |             ^~~~
talloc/replace.h:14:13: note: ‘bool’ is a keyword with ‘-std=c23’ onwards
talloc/replace.h:14:1: warning: useless type name in empty declaration
   14 | typedef int bool;
      | ^~~~~~~
error: command '/usr/bin/gcc' failed with exit code 1

ERROR Backend subprocess exited when trying to invoke build_wheel
==> ERROR: A failure occurred in build().
    Aborting...
:: Unable to build python-pytsk3 - makepkg exited with code: 4

[joachimmetz]

thanks, will take a closer look.

[joachimmetz]

@arnonuehm66 feel free to give the changes in #111 a try, these changes allow me to build the source on Fedora 42