Implement long/narrow -> short fallback in babel.units#1225
Open
trillllian wants to merge 2 commits intopython-babel:masterfrom
Open
Implement long/narrow -> short fallback in babel.units#1225trillllian wants to merge 2 commits intopython-babel:masterfrom
trillllian wants to merge 2 commits intopython-babel:masterfrom
Conversation
Author
|
hi, i noticed 2.18.0 was released recently. is there any chance someone could take a look at this PR? it is really not a complicated fix in my opinion, and this bug causes quite a few strings in our application to go untranslated. (well, currently it's not much of a problem since we are using babel 2.12 which has a much older CLDR, but it would be nice to upgrade.) thanks for all the great work on babel regardless! |
akx
approved these changes
Apr 10, 2026
Member
akx
left a comment
akx
left a comment
There was a problem hiding this comment.
LGTM, one tiny performance note.
Sorry reviewing this had fallen through the cracks!
Also implemented fallback from the correct pluralization to "other", which was also missing. Fixes python-babel#1217.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1225 +/- ##
==========================================
+ Coverage 92.04% 92.05% +0.01%
==========================================
Files 27 27
Lines 4715 4721 +6
==========================================
+ Hits 4340 4346 +6
Misses 375 375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Aarni Koskela <akx@iki.fi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also implemented fallback from the correct pluralization to "other", which was also missing.
Fixes #1217.