Implement <svg> support

[efoken]

#4

[efoken]

Let me know what you think @necolas

There are still some $FlowFixMe that I added inside createStrictDOMSvgComponent which can be fixed by changing the NativeProps type, but I was not sure if that's the best place, or if it may be better to have a bit more differentiation between React Native Props and React Native SVG Props.

Also I am willing to add some tests and probably some examples in the Expo examples app.

[necolas]

Thanks for sharing this quickly and early.

My initial thoughts are that the HTML and SVG interfaces are too intermingled in the code. Although html.svg seemed to make sense at first, I have doubts after looking through this patch and doing a bit more research.

The <svg> element is type SVGSVGElement. So writing <svg.svg> in RSD would be true to spec. And eventually there might be <html.html> as well.

If we were to put everything SVG (inc the <svg> element) under the svg export, it would help keep a clearer separation between HTML and SVG types and logic. DCE has a better chance of removing all the SVG code too.

So in general, having separate Svg functions and checks seems like the better way forward to me. And we can refactor/rename any code that needs to be shared as and where it's needed.

[nandorojo]

This PR is great timing! I just happened to do something similar in my app via a patch and was playing with it before sending a PR. Thanks moving so quickly on it.

[MoOx]

Is something causing any trouble that we could fix to move forward with this ?

[MoOx]

@efoken I just saw that you published https://github.com/efoken/react-strict-dom-svg @martinbooth do you think this could be merged into RSD repo ?

[efoken]

@MoOx @martinbooth I updated my PR, ist there anything we can do to get this merged?

[MoOx]

You might want to read from here #4 (comment)
and also this #479

[efoken]

@MoOx I moved everything to a react-strict-svg package, please have a look. I can also remove my published react-strict-dom-svg package after this is merged and published.

[MoOx]

Sadly I am no decider here. poke @martinbooth or fb team