Ignore undefined style values on native#498
Open
adityasingh2400 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #452
On native, returning
undefinedfor a property from an inline style function (or any style object with an undefined value) leaks that key throughprocessStyleand into the style resolver, which throwsstyleq: <cssAtom> typeof undefined is not "string" or "null". This is a regression; these values used to be dropped, and on web undefined values are simply ignored.The loop in
processStylebranches onobject/string/number, so an undefined value falls through to the catch-all assignment and ends up in the result as{ rowGap: undefined }. This adds an earlycontinuefor undefined values so the property is omitted, matching web behavior and letting inline style functions return undefined to opt out of a property.nullis left untouched since the resolver accepts it.Testing: added a regression test under
css.create() > values: generalthat asserts the property is absent when the inline function returns undefined. Confirmed it fails onmainand passes with the fix. Full native + web jest suites pass (888 tests, 711 snapshots unchanged), Flow and ESLint clean.Reopening this. I closed it by accident during a bulk cleanup of my stale forks and cannot reopen the original because the fork was deleted, so this is the same branch restored. Sorry for the noise @MoOx.