You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Found out with some dependency upgrades, that bridgectl started requiring libssl to be installed because of default-features in reqwest. Now this is okay for now, as packages aren't actually stable, and ready to be truly used anyway. I've also disabled the features in reqwest in my PCFS branch so that way packages will go back to only depending on libc & libgcc for now.
However, it does bring up a point, that we never actually validate the packages, 'just work' (e.g. do we need to do anything special for mac/windows packaging w.r.t dependencies?; not last i checked, but maybe my testbeds just happened to have the correct things installed).
As a result at some point before publishing packages, we should actually validate installed packages work, and that they work in PR's (incase anyone's new dependencies introduce libraries in the binaries that need to be added).
Found out with some dependency upgrades, that
bridgectlstarted requiring libssl to be installed because of default-features inreqwest. Now this is okay for now, as packages aren't actually stable, and ready to be truly used anyway. I've also disabled the features in reqwest in my PCFS branch so that way packages will go back to only depending on libc & libgcc for now.However, it does bring up a point, that we never actually validate the packages, 'just work' (e.g. do we need to do anything special for mac/windows packaging w.r.t dependencies?; not last i checked, but maybe my testbeds just happened to have the correct things installed).
As a result at some point before publishing packages, we should actually validate installed packages work, and that they work in PR's (incase anyone's new dependencies introduce libraries in the binaries that need to be added).