incorrect function syntax color

[chrisdp]

fromSeconds, AssertEqual, getParent should be yellow like the fromISO8601String function call.

[TwitchBronBron]

I feel like there might be something else at play here, because all of my functions are coloring properly. Do you have any custom color settings?

sub Main()
    if (type(time) = "String") or (type(time) = "roString")
        m.date.fromISO8601String(time)
    else
        date.fromSeconds(time)
    end if

    if isNode(node) then
        node.getParent().removeChild(node)
    end if

    m.AssertEqual(expected, date_getTimeStampFromTime(time))
end sub

[tomek-r]

hi,
I have the same issue as @chrisdp

It seems to be caused by one of the latest updates.

Edit: I installed manually 1.19.5 and it fixes the issue.

[chrisdp]

@tomek-r This was fixed in the latest release of 1.20.1 Can you please verify and I will close this issue.

[tomek-r]

@chrisdp thank you for updates.

1.20.1 is partial fix. There is still issue with if, while and m.top.

[chrisdp]

Ah thanks. Will try and take a look. I didn’t catch that because I didn’t have my conditionals wrapped like you.

[TwitchBronBron]

Looks like if and m.top have been fixed, but while is still wrong.

I think this can be fixed by updating the if_with_paren pattern here (let's just rename that to if_or_while_with_paren and support both if and while.

vscode-brightscript-language/syntaxes/brightscript.tmLanguage.json

Lines 692 to 710 in 340d660

	"if_with_paren": {
	"begin": "(?i:(?<!\\.)(if)\\s*\\()",
	"beginCaptures": {
	"1": {
	"name": "keyword.control.brs"
	}
	},
	"patterns": [
	{
	"include": "#entire_language"
	}
	],
	"end": "\b(then)|\n",
	"endCaptures": {
	"1": {
	"name": "keyword.control.brs"
	}
	}
	},

[philanderson888]

work in progress merge request on this issue

@chrisdp @TwitchBronBron @tomek-r

#611