From dcab982d7e383b0690fb37182b804f537a61786b Mon Sep 17 00:00:00 2001 From: Luke Piette Date: Mon, 31 Aug 2026 13:40:38 -0400 Subject: [PATCH 1/3] Bump ComfyUI to 0.34.0; fix Docker Hub description sync for org tokens Pin ComfyUI 0.34.0 in Dockerfile and docker-bake.hcl (was 0.29.0). Replace peter-evans/dockerhub-description (legacy Hub API, rejects organization access tokens) with a direct PATCH to the namespaces endpoint, and move GitHub release creation ahead of it so a description failure can't abort the release. Co-Authored-By: Claude Fable 5 --- .changeset/bump-comfyui-0-34.md | 7 +++++++ .github/workflows/release.yml | 26 +++++++++++++++++++------- Dockerfile | 2 +- docker-bake.hcl | 2 +- 4 files changed, 28 insertions(+), 9 deletions(-) create mode 100644 .changeset/bump-comfyui-0-34.md diff --git a/.changeset/bump-comfyui-0-34.md b/.changeset/bump-comfyui-0-34.md new file mode 100644 index 000000000..e25bf58b6 --- /dev/null +++ b/.changeset/bump-comfyui-0-34.md @@ -0,0 +1,7 @@ +--- +"worker-comfyui": minor +--- + +Bump the pinned ComfyUI version from 0.29.0 to 0.34.0 (current upstream latest). Workflows exported from recent ComfyUI versions use core nodes that don't exist in 0.29-era images and fail at runtime with "missing node" errors — notably every image consumed as a base by comfyui-wizard. ComfyUI's dependency floors are unchanged between 0.29 and 0.34, so the existing torch 2.11.0+cu128 and transformers<5 pins still apply, and the build-time smoke test gates startup. + +Also fixes the release workflow's Docker Hub description sync: the previous action authenticated via Docker Hub's legacy user-login API, which rejects organization access tokens unconditionally — it 401'd on every release since the org token rotation and aborted the job before the GitHub release was created (5.9.0 had to be backfilled by hand). The step is now a direct PATCH to the modern namespaces endpoint using the same token, and runs after the GitHub release step so a description failure can never block a release again. diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 8c56adec5..2f26ef2fc 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -132,14 +132,26 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Update description on Docker Hub - uses: peter-evans/dockerhub-description@v3 - with: - username: ${{ secrets.DOCKERHUB_USERNAME }} - password: ${{ secrets.DOCKERHUB_TOKEN }} - repository: ${{ vars.DOCKERHUB_REPO }}/${{ vars.DOCKERHUB_IMG }} - - name: Create GitHub release env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: gh release create "${{ needs.release.outputs.version }}" --generate-notes + + # peter-evans/dockerhub-description uses the legacy Hub API + # (/v2/users/login + /v2/repositories/...), which rejects organization + # access tokens with 401/403 regardless of scopes. The namespaces + # endpoint accepts the org token as a Bearer token directly. + # Runs after the GitHub release so a description failure can't block it. + - name: Update description on Docker Hub + env: + DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }} + DOCKERHUB_REPO: ${{ vars.DOCKERHUB_REPO }} + DOCKERHUB_IMG: ${{ vars.DOCKERHUB_IMG }} + run: | + jq -n --rawfile readme README.md '{full_description: $readme}' \ + | curl -sSf -X PATCH \ + -H "Authorization: Bearer ${DOCKERHUB_TOKEN}" \ + -H "Content-Type: application/json" \ + -d @- \ + -o /dev/null \ + "https://hub.docker.com/v2/namespaces/${DOCKERHUB_REPO}/repositories/${DOCKERHUB_IMG}" diff --git a/Dockerfile b/Dockerfile index fead207da..1dd71a953 100644 --- a/Dockerfile +++ b/Dockerfile @@ -5,7 +5,7 @@ ARG BASE_IMAGE=nvidia/cuda:12.8.1-cudnn-runtime-ubuntu24.04 FROM ${BASE_IMAGE} AS base # Build arguments for this stage with sensible defaults for standalone builds -ARG COMFYUI_VERSION=0.29.0 +ARG COMFYUI_VERSION=0.34.0 ARG CUDA_VERSION_FOR_COMFY=12.8 ARG ENABLE_PYTORCH_UPGRADE=false ARG PYTORCH_INDEX_URL diff --git a/docker-bake.hcl b/docker-bake.hcl index 6c5632450..b463dbac3 100644 --- a/docker-bake.hcl +++ b/docker-bake.hcl @@ -11,7 +11,7 @@ variable "RELEASE_VERSION" { } variable "COMFYUI_VERSION" { - default = "0.29.0" + default = "0.34.0" } # Global defaults for standard CUDA 12.8.1 images From c61399899eff5cc9b5c53c2f8bd11a9a39538cc8 Mon Sep 17 00:00:00 2001 From: Luke Piette Date: Mon, 31 Aug 2026 14:00:09 -0400 Subject: [PATCH 2/3] Correct changeset: 5.9.0 GitHub release was never created Co-Authored-By: Claude Fable 5 --- .changeset/bump-comfyui-0-34.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/bump-comfyui-0-34.md b/.changeset/bump-comfyui-0-34.md index e25bf58b6..2f42b9fe4 100644 --- a/.changeset/bump-comfyui-0-34.md +++ b/.changeset/bump-comfyui-0-34.md @@ -4,4 +4,4 @@ Bump the pinned ComfyUI version from 0.29.0 to 0.34.0 (current upstream latest). Workflows exported from recent ComfyUI versions use core nodes that don't exist in 0.29-era images and fail at runtime with "missing node" errors — notably every image consumed as a base by comfyui-wizard. ComfyUI's dependency floors are unchanged between 0.29 and 0.34, so the existing torch 2.11.0+cu128 and transformers<5 pins still apply, and the build-time smoke test gates startup. -Also fixes the release workflow's Docker Hub description sync: the previous action authenticated via Docker Hub's legacy user-login API, which rejects organization access tokens unconditionally — it 401'd on every release since the org token rotation and aborted the job before the GitHub release was created (5.9.0 had to be backfilled by hand). The step is now a direct PATCH to the modern namespaces endpoint using the same token, and runs after the GitHub release step so a description failure can never block a release again. +Also fixes the release workflow's Docker Hub description sync: the previous action authenticated via Docker Hub's legacy user-login API, which rejects organization access tokens unconditionally — it 401'd on every release since the org token rotation and aborted the job before the GitHub release was created (5.9.0's images shipped to Docker Hub, but its GitHub release was never created, so the Hub never indexed it). The step is now a direct PATCH to the modern namespaces endpoint using the same token, and runs after the GitHub release step so a description failure can never block a release again. From 7238b6fc64546dfcbced9b3f6573e5a52269ff16 Mon Sep 17 00:00:00 2001 From: Luke Piette Date: Mon, 31 Aug 2026 14:56:43 -0400 Subject: [PATCH 3/3] Widen allowedCudaVersions to include 13.1 and 13.2 The image bundles its own CUDA 12.8 runtime; hosts advertising newer CUDA versions satisfy the driver floor and run it unchanged. Without these entries, endpoints were locked out of hosts reporting 13.1/13.2 (most RTX 5090 and RTX PRO 6000 capacity). Co-Authored-By: Claude Fable 5 --- .changeset/bump-comfyui-0-34.md | 2 ++ .runpod/hub.json | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.changeset/bump-comfyui-0-34.md b/.changeset/bump-comfyui-0-34.md index 2f42b9fe4..4351d5c12 100644 --- a/.changeset/bump-comfyui-0-34.md +++ b/.changeset/bump-comfyui-0-34.md @@ -4,4 +4,6 @@ Bump the pinned ComfyUI version from 0.29.0 to 0.34.0 (current upstream latest). Workflows exported from recent ComfyUI versions use core nodes that don't exist in 0.29-era images and fail at runtime with "missing node" errors — notably every image consumed as a base by comfyui-wizard. ComfyUI's dependency floors are unchanged between 0.29 and 0.34, so the existing torch 2.11.0+cu128 and transformers<5 pins still apply, and the build-time smoke test gates startup. +Also widens `allowedCudaVersions` to include 13.1 and 13.2. The image bundles its own CUDA 12.8 runtime, so any host with a driver at or beyond the 12.8 floor (driver >= 570) runs it identically — newer host CUDA versions are backward compatible. Without this, endpoints were locked out of the growing share of hosts advertising 13.1/13.2 (including most RTX 5090 and RTX PRO 6000 capacity). + Also fixes the release workflow's Docker Hub description sync: the previous action authenticated via Docker Hub's legacy user-login API, which rejects organization access tokens unconditionally — it 401'd on every release since the org token rotation and aborted the job before the GitHub release was created (5.9.0's images shipped to Docker Hub, but its GitHub release was never created, so the Hub never indexed it). The step is now a direct PATCH to the modern namespaces endpoint using the same token, and runs after the GitHub release step so a description failure can never block a release again. diff --git a/.runpod/hub.json b/.runpod/hub.json index 23291461c..bc8d19810 100644 --- a/.runpod/hub.json +++ b/.runpod/hub.json @@ -9,7 +9,7 @@ "containerDiskInGb": 20, "gpuIds": "ADA_24", "gpuCount": 1, - "allowedCudaVersions": ["12.8", "12.9", "13.0"], + "allowedCudaVersions": ["12.8", "12.9", "13.0", "13.1", "13.2"], "env": [ { "key": "COMFY_ORG_API_KEY",