Bump hyrax to include #7470 (strip default locale from URLs)#3071
Bump hyrax to include #7470 (strip default locale from URLs)#3071ShanaLMoore wants to merge 2 commits into
Conversation
Pulls in default_url_options fix so default-locale URLs no longer carry ?locale=en, eliminating locale-pollution in sitemap entries and canonical tags. Refs: notch8/hykuup_knapsack#677 Upstream: samvera/hyrax#7470 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Test Results 3 files ±0 3 suites ±0 14m 41s ⏱️ +33s Results for commit d724e7a. ± Comparison against base commit b45c6b1. This pull request removes 46 and adds 46 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Post hyrax#7470, Hyrax::Controller#default_url_options no longer appends `locale: I18n.locale` when the active locale is the default, so URL helpers and redirect paths for default-locale (en) responses come out without `?locale=en`. These specs were pinning the old behavior; updating them to match. Refs: notch8/hykuup_knapsack#677 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Marking this draft. While verifying the bump on Hyrax revert PR: samvera/hyrax#7476. Once that merges and a follow-up addresses the underlying locale-leak in Hyrax, I'll un-draft this PR (or open a fresh one bumping to the corrected SHA). |
Summary
hyraxpin to7f0e346a37c15330dd664ecfac203aa8e7d5c416, the merge commit of Strip default locale from default_url_options hyrax#7470.Hyrax::Controller#default_url_optionsonly emitlocale: I18n.localewhen the active locale differs fromI18n.default_locale, so default-locale URLs no longer carry?locale=en.Refs: notch8/hykuup_knapsack#677
Upstream: samvera/hyrax#7470
Why
Hyku's sitemap entries, canonical tags, and outbound links were all rendering as
?locale=eneven for default-locale visitors. Googlebot picked those locale-parameterized URLs up as canonical, which led to foreign-language variants ranking ahead of English results on Truman (the original symptom in #677). The companion canonical-tag work already landed in #3067; this bump is the URL-level cleanup that needs to land before those canonicals start emitting (otherwise the canonicals themselves would re-declare?locale=enURLs as authoritative).Behavior
I18n.default_locale(en){ locale: :en }appended to every URL{}:es){ locale: :es }{ locale: :es }(unchanged)Test plan
dev-hyku.localhost.directwith this lockfile applied:/dashboard?locale=en: 0 of 45 anchors carry?locale=enother than the language-switcher itself./catalog?locale=es: in-app links correctly carry?locale=es(/about?locale=es,/single_signon?locale=es, etc.).site:truman.digitalmobius.org inurl:locale=trend over 2-6 weeks. (in hyku up)🤖 Generated with Claude Code