Skip to content

Pin json ~> 2.0#3095

Closed
ShanaLMoore wants to merge 1 commit into
mainfrom
pin-blacklight-advanced-search-and-json
Closed

Pin json ~> 2.0#3095
ShanaLMoore wants to merge 1 commit into
mainfrom
pin-blacklight-advanced-search-and-json

Conversation

@ShanaLMoore

@ShanaLMoore ShanaLMoore commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Knapsacks gitignore Gemfile.lock and re-resolve from scratch in CI, so unpinned gems can drift to incompatible majors (e.g. json 3.x).

Pinning json at the Hyku level keeps every downstream resolving to a compatible version without each one overriding via bundler.d.

ref: https://notch8.slack.com/archives/C08EHRPQ9MY/p1780929216187279

image

@samvera/hyku-code-reviewers

@ShanaLMoore ShanaLMoore marked this pull request as ready for review June 8, 2026 15:40
@ShanaLMoore ShanaLMoore marked this pull request as draft June 8, 2026 15:40
@ShanaLMoore ShanaLMoore added the ignore-for-release ignore this for release notes label Jun 8, 2026

@maxkadel maxkadel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ShanaLMoore!

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Test Results

    3 files  ±0      3 suites  ±0   14m 10s ⏱️ - 1m 4s
2 463 tests ±0  2 404 ✅ ±0  59 💤 ±0  0 ❌ ±0 
2 490 runs  ±0  2 429 ✅ ±0  61 💤 ±0  0 ❌ ±0 

Results for commit 951fd17. ± Comparison against base commit fdd4986.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy a2704dbe-8f4e-4c4f-958e-47563a063d46
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit b1c487bb-14a2-4cca-84ba-071499d9f8fe
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 30c6ab38-d504-44e6-abb3-04001a0e8e0c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 078cb458-625c-4827-8d46-7ec26e5b0063
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 5f921981-c54c-4128-9e4e-fe4c09f77aad
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 8d9476e1-b3b2-4524-9c3d-3951964d48ce
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read a4f0837d-a3b8-4080-a290-15a312e9908f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update af1a9c42-fc07-48d8-bdbc-6a6453311b3f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 6dcd8498-afeb-4933-b1ef-a2aa06e5b216
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 621c1a72-90d4-4e92-9e8f-bfdb3171010b
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 34ef1911-d060-4493-b80a-9731c7b52571
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit abdf703e-a97a-489b-8d93-fa0dd28687f4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read f025c08c-5dbc-453c-a2a8-5fe0c0823165
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 70dd3aa7-8492-4833-88fa-57a0020a0322
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 9623b71f-db4b-46cf-aff4-32332124b2ae
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 50d92ffc-9061-4263-8b00-357c620f7087
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 659837c8-adaf-457f-98a8-58aaff3f1014
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 0cf3f9f8-161b-45ea-a182-01e626f0046e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 8b1a0abf-632f-4626-a389-8ea7050ce81d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 8731743c-936e-489c-b90e-7ee7e0a7542d
…

@maxkadel maxkadel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoot, I think I was wrong about blacklight_advanced_search needing to be pinned - I think v8 should be compatible with BL 7 - it was just a specific test that failed in that one knapsack.

I do think we need the json pin, though.

Comment thread Gemfile Outdated
gem 'bixby', group: %i[development test]
gem 'blacklight', '~> 7.38' # Updated for Rails 7.2 compatibility
gem 'blacklight_advanced_search'
gem 'blacklight_advanced_search', '~> 7.0' # v8 introduces breaking changes

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into this more, I think I was wrong - I think it was an individual test for that knapsack that failed with the new version, but I think v8 should be non-breaking.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closed and replaced by #3096

Knapsacks gitignore Gemfile.lock and re-resolve from scratch in CI, so
unpinned gems can drift to incompatible majors (e.g. json 3.x).

Pinning json at the Hyku level keeps every downstream resolving to a
compatible version without each one overriding via bundler.d.

ref: https://notch8.slack.com/archives/C08EHRPQ9MY/p1780929216187279
@ShanaLMoore ShanaLMoore force-pushed the pin-blacklight-advanced-search-and-json branch from 951fd17 to 187b83b Compare June 8, 2026 16:21
@ShanaLMoore ShanaLMoore changed the title Pin blacklight_advanced_search ~> 7.0 and json ~> 2.0 Pin json ~> 2.0 Jun 8, 2026
@ShanaLMoore ShanaLMoore closed this Jun 8, 2026
@ShanaLMoore ShanaLMoore deleted the pin-blacklight-advanced-search-and-json branch June 8, 2026 16:22
@ShanaLMoore ShanaLMoore restored the pin-blacklight-advanced-search-and-json branch June 8, 2026 16:23
@ShanaLMoore ShanaLMoore reopened this Jun 8, 2026
@ShanaLMoore ShanaLMoore closed this Jun 8, 2026
@ShanaLMoore ShanaLMoore deleted the pin-blacklight-advanced-search-and-json branch June 8, 2026 16:23
@ShanaLMoore ShanaLMoore restored the pin-blacklight-advanced-search-and-json branch June 8, 2026 16:23
@ShanaLMoore ShanaLMoore reopened this Jun 8, 2026
@ShanaLMoore ShanaLMoore closed this Jun 8, 2026
@ShanaLMoore ShanaLMoore deleted the pin-blacklight-advanced-search-and-json branch June 8, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release ignore this for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants