Skip to content

Pin json ~> 2.0#3096

Draft
ShanaLMoore wants to merge 1 commit into
mainfrom
pin-json-version
Draft

Pin json ~> 2.0#3096
ShanaLMoore wants to merge 1 commit into
mainfrom
pin-json-version

Conversation

@ShanaLMoore

Copy link
Copy Markdown
Collaborator

Knapsacks gitignore Gemfile.lock and re-resolve from scratch in CI, so unpinned gems can drift to incompatible majors (e.g. json 3.x).

Pinning json at the Hyku level keeps every downstream resolving to a compatible version without each one overriding via bundler.d.

ref: https://notch8.slack.com/archives/C08EHRPQ9MY/p1780929216187279

image

@samvera/hyku-code-reviewers

Knapsacks gitignore Gemfile.lock and re-resolve from scratch in CI, so
unpinned gems can drift to incompatible majors (e.g. json 3.x).

Pinning json at the Hyku level keeps every downstream resolving to a
compatible version without each one overriding via bundler.d.

ref: https://notch8.slack.com/archives/C08EHRPQ9MY/p1780929216187279
@ShanaLMoore ShanaLMoore marked this pull request as draft June 8, 2026 16:44
@ShanaLMoore ShanaLMoore mentioned this pull request Jun 8, 2026
@ShanaLMoore ShanaLMoore added the ignore-for-release ignore this for release notes label Jun 8, 2026
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Test Results

    3 files  ±0      3 suites  ±0   15m 3s ⏱️ -11s
2 463 tests ±0  2 404 ✅ ±0  59 💤 ±0  0 ❌ ±0 
2 490 runs  ±0  2 429 ✅ ±0  61 💤 ±0  0 ❌ ±0 

Results for commit 5f17b79. ± Comparison against base commit fdd4986.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy a2704dbe-8f4e-4c4f-958e-47563a063d46
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit b1c487bb-14a2-4cca-84ba-071499d9f8fe
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 30c6ab38-d504-44e6-abb3-04001a0e8e0c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 078cb458-625c-4827-8d46-7ec26e5b0063
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 5f921981-c54c-4128-9e4e-fe4c09f77aad
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 8d9476e1-b3b2-4524-9c3d-3951964d48ce
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read a4f0837d-a3b8-4080-a290-15a312e9908f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update af1a9c42-fc07-48d8-bdbc-6a6453311b3f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 6dcd8498-afeb-4933-b1ef-a2aa06e5b216
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 621c1a72-90d4-4e92-9e8f-bfdb3171010b
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 3ad29451-ff78-4bb7-bd8e-1276a1988a32
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 8da61421-3763-49ef-9dbb-56acd19fe38f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 44a5b67d-3032-43ac-ab2a-769545f05416
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 531c63a8-3f95-4b8b-ad03-912a30e600b3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy c3903bc2-e944-4e49-96b2-1b07befbdc05
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 8f5588a0-0211-4f05-8d9c-9b27fb80084c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read c2978bfc-fea1-421b-b133-72495a9dfadd
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 92097781-ddc6-46d7-ad1a-09b85f45b3f9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy da936cd9-97d2-4783-bedf-36b1749baee6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 5f89db69-7df1-4f93-addb-5c9d62547c9c
…

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release ignore this for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant