- Branch off of
develop! PRs tomasterwill get closed without consideration. - Before opening a PR, make sure that you rebased the latest master and that your PR can get merged right away.
- Make sure shadow-build is not complaining about any warnings / errors related to your change.
- Use the dot syntax for javascript interop
;; Good
(.hello js/window)
;; Bad
(. js/window (hello))- Use
:asin:require. Avoid:use.
;; good
(ns examples.ns
(:require [clojure.zip :as zip]))
;; good
(ns examples.ns
(:require [clojure.zip :refer [lefts rights]))
;; acceptable as warranted
(ns examples.ns
(:require [clojure.zip :refer :all]))
;; bad
(ns examples.ns
(:use clojure.zip))more to come