Make epoll-multiplexer thread safe#28
Conversation
57f603a to
41af7c7
Compare
|
@sionescu, what's the deal with this? shall i rebase it? will you merge it? i need it in our production systems and it's a headache to keep it in sync with master. |
|
@sionescu any decision on this? do you theoretically agree to this? i understand if you have no time to deal with it right now. i just want to know what to expect in the future, because we need to maintain a separate repo for this single patch to build our production systems (as opposed to simply getting iolib from quicklisp). |
41af7c7 to
b24c3d6
Compare
Instead of a preallocated slot use WITH-FOREIGN-OBJECT to allocate the events array, and thus make HARVEST-EVENTS safe for concurrent calls.
b24c3d6 to
4b64aec
Compare
|
i had to rebase this, it should merge fine into the current master. |
|
Hi @sionescu, as a hu.dwim.web-server user, I'm also interested in this patch. Thank you |
|
@sionescu i'm still maintaining this several years later, but it's quite a straightforward patch: it just moves the allocation of the buffer to the thread instead of a shared slot on the object. and i doubt it has serious performance implications. any reason this is still not merged? this was needed to fix an actually manifesting bug in our webapps. |
GitHub Pull Request: #28 Make epoll-multiplexer thread safe Instead of a preallocated slot use WITH-FOREIGN-OBJECT to allocate the events array, and thus make HARVEST-EVENTS safe for concurrent calls. Patch-set: 1 Change-id: I64a679e6b869b3c40cbd7a95b83fc08003933e6c Subject: Make epoll-multiplexer thread safe Branch: refs/heads/master Status: new Topic: Commit: 4b64aec Tag: autogenerated:gerrit:newPatchSet Groups: 4b64aec Private: false Work-in-progress: false
this fixes the delay bugs, but requires a pending fix into iolib. see sionescu/iolib#28
Instead of a preallocated slot use WITH-FOREIGN-OBJECT to allocate
the events array, and thus make HARVEST-EVENTS safe for concurrent calls.