From 2c00a0e7c93d94f1b8afa1050f0b4968bff29fff Mon Sep 17 00:00:00 2001 From: Riccardo Cappuzzo Date: Mon, 15 Jun 2026 09:45:27 +0200 Subject: [PATCH 1/3] FIX - leftover fixes from other PRs --- CHANGES.rst | 2 ++ skrub/_agg_joiner.py | 2 +- skrub/_joiner.py | 8 ++++++-- skrub/_multi_agg_joiner.py | 5 +++-- 4 files changed, 12 insertions(+), 5 deletions(-) diff --git a/CHANGES.rst b/CHANGES.rst index 40c6d1230..ca4910732 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -54,6 +54,8 @@ Changes :pr:`2096` by :user:`Ayesha Siddiqua `. - The :class:`TableReport` can now be exported in markdown format with ``.markdown``. :pr:`2048` by :user:`Riccardo Cappuzzo `. +- The minimum required version of matplotlib has been increased from 3.4.3 to 3.6.1. + :pr:`2159` by :user:`Riccardo Cappuzzo `. Bugfixes -------- diff --git a/skrub/_agg_joiner.py b/skrub/_agg_joiner.py index b71a9ea7d..46ea4b06c 100644 --- a/skrub/_agg_joiner.py +++ b/skrub/_agg_joiner.py @@ -188,7 +188,7 @@ class AggJoiner(TransformerMixin, BaseEstimator): not be reflected in the transformed output. If you need to update the auxiliary table, you will need to refit the transformer. - Consider using the :ref:`skrub Data Ops <_user_guide_data_ops_index>` + Consider using the :ref:`skrub Data Ops ` and a standard dataframe library (Pandas or Polars) to perform the aggregation instead. diff --git a/skrub/_joiner.py b/skrub/_joiner.py index 956062188..dab1ad96d 100644 --- a/skrub/_joiner.py +++ b/skrub/_joiner.py @@ -96,11 +96,15 @@ class Joiner(TransformerMixin, BaseEstimator): Additionally, the auxiliary table is stored in memory as part of the state of the transformer, which can lead to high memory usage if the auxiliary table is large. - Moreover, it is frozen in memory after fitting, which means that if the - auxiliary table is modified after fitting, the changes will not be reflected + Moreover, the auxiliary table is frozen in memory after fitting, which means + that if the auxiliary table is modified after fitting, the changes will + not be reflected in the transformed output. If you need to update the auxiliary table, you will need to refit the transformer. + Consider using the :ref:`skrub Data Ops ` + framework instead. + Parameters ---------- diff --git a/skrub/_multi_agg_joiner.py b/skrub/_multi_agg_joiner.py index e4d623615..3c0dff5d8 100644 --- a/skrub/_multi_agg_joiner.py +++ b/skrub/_multi_agg_joiner.py @@ -29,8 +29,9 @@ class MultiAggJoiner(TransformerMixin, BaseEstimator): .. warning:: The auxiliary table is stored in memory as part of the state of the transformer, which can lead to high memory usage if the auxiliary table is large. - Consider using the skrub Data Ops and a standard dataframe library (Pandas - or Polars) to perform the aggregation instead. + Consider using the :ref:`skrub Data Ops ` and + a standard dataframe library (Pandas or Polars) to perform the aggregation + instead. Parameters ---------- From a55ff0bf0581b9e1d8c6d29bc8a7f4f6f6f5a439 Mon Sep 17 00:00:00 2001 From: Riccardo Cappuzzo Date: Mon, 15 Jun 2026 09:47:17 +0200 Subject: [PATCH 2/3] _ --- skrub/_joiner.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/skrub/_joiner.py b/skrub/_joiner.py index dab1ad96d..67ea7e38b 100644 --- a/skrub/_joiner.py +++ b/skrub/_joiner.py @@ -102,10 +102,6 @@ class Joiner(TransformerMixin, BaseEstimator): in the transformed output. If you need to update the auxiliary table, you will need to refit the transformer. - Consider using the :ref:`skrub Data Ops ` - framework instead. - - Parameters ---------- aux_table : dataframe From 0b67d479bc75d5590664d2ba605355ab9cccf58a Mon Sep 17 00:00:00 2001 From: Riccardo Cappuzzo Date: Mon, 15 Jun 2026 12:02:25 +0200 Subject: [PATCH 3/3] _ --- skrub/_joiner.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/skrub/_joiner.py b/skrub/_joiner.py index 67ea7e38b..895f52bc3 100644 --- a/skrub/_joiner.py +++ b/skrub/_joiner.py @@ -97,8 +97,7 @@ class Joiner(TransformerMixin, BaseEstimator): of the transformer, which can lead to high memory usage if the auxiliary table is large. Moreover, the auxiliary table is frozen in memory after fitting, which means - that if the auxiliary table is modified after fitting, the changes will - not be reflected + that if it is modified after fitting, the changes will not be reflected in the transformed output. If you need to update the auxiliary table, you will need to refit the transformer.