From 076af57e99afbb31e66af2e6ded3d6d65c5ce85d Mon Sep 17 00:00:00 2001
From: Mathieu Poumeyrol <kali@zoy.org>
Date: Mon, 13 Jul 2026 08:45:03 +0000
Subject: [PATCH] Don't force RUST_BACKTRACE=1 on remote runs
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The ssh and android runners hardcoded RUST_BACKTRACE=1 into the remote command,
forcing a backtrace capture on every error in the run — cheap on most hosts but
pathologically slow on constrained targets (a static musl aarch64 board can
spend seconds per capture), which dominated cross-run time. Drop it; callers
that want backtraces can still pass -e RUST_BACKTRACE=1.
---
 dinghy-lib/src/android/device.rs | 2 +-
 dinghy-lib/src/ssh/device.rs     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dinghy-lib/src/android/device.rs b/dinghy-lib/src/android/device.rs
index dce112a3..c124cfdc 100644
--- a/dinghy-lib/src/android/device.rs
+++ b/dinghy-lib/src/android/device.rs
@@ -235,7 +235,7 @@ impl Device for AndroidDevice {
             .collect();
         let (build_bundle, remote_bundle) = self.install_app(&project, &build)?;
         let command = format!(
-                "cd '{}'; RUST_BACKTRACE=1 {} DINGHY=1 LD_LIBRARY_PATH=\"{}:$LD_LIBRARY_PATH\" {} {} ; echo FORWARD_RESULT_TO_DINGHY_BECAUSE_ADB_DOES_NOT=$?",
+                "cd '{}'; {} DINGHY=1 LD_LIBRARY_PATH=\"{}:$LD_LIBRARY_PATH\" {} {} ; echo FORWARD_RESULT_TO_DINGHY_BECAUSE_ADB_DOES_NOT=$?",
                 path_to_str(&remote_bundle.bundle_dir)?,
                 envs.join(" "),
                 path_to_str(&remote_bundle.lib_dir)?,
diff --git a/dinghy-lib/src/ssh/device.rs b/dinghy-lib/src/ssh/device.rs
index 9e5ea30a..3fe501bc 100644
--- a/dinghy-lib/src/ssh/device.rs
+++ b/dinghy-lib/src/ssh/device.rs
@@ -229,7 +229,7 @@ impl Device for SshDevice {
         let (build_bundle, remote_bundle) = self.install_app(&project, &build)?;
         log::debug!("Installed {:?}", build.runnable.id);
         let command = format!(
-            "cd '{}' ; RUST_BACKTRACE=1 {} DINGHY=1 LD_LIBRARY_PATH=\"{}:$LD_LIBRARY_PATH\" {} {}",
+            "cd '{}' ; {} DINGHY=1 LD_LIBRARY_PATH=\"{}:$LD_LIBRARY_PATH\" {} {}",
             path_to_str(&remote_bundle.bundle_dir)?,
             envs.join(" "),
             path_to_str(&remote_bundle.lib_dir)?,