From ea509476a3738cc8c73587b59affdb6c68ab6f60 Mon Sep 17 00:00:00 2001 From: Harmen Stoppels Date: Wed, 29 Apr 2026 13:34:00 +0200 Subject: [PATCH 1/2] openblas: use default make target Running `make libs && make netlib && make shared` causes the `ar` commands two run twice, which is surprisingly slow. The reason we didn't run just `make` was because it build and runs tests unconditionally, and that sometimes broke. I think if it's broken then the tests should be fixed. Signed-off-by: Harmen Stoppels --- repos/spack_repo/builtin/packages/openblas/package.py | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/repos/spack_repo/builtin/packages/openblas/package.py b/repos/spack_repo/builtin/packages/openblas/package.py index 0a6e7fdbb53..c173f738004 100644 --- a/repos/spack_repo/builtin/packages/openblas/package.py +++ b/repos/spack_repo/builtin/packages/openblas/package.py @@ -621,15 +621,10 @@ def make_defs(self): def build(self, pkg: MakefilePackage, spec: Spec, prefix: Prefix) -> None: """Override 'make all' with sequential builds due to race conditions.""" - # Due to the verbosity of the command line and number of object files - # created, we suppress makefile command echoing via `-s`. - args = ["-s"] + self.make_defs - - # Make each target sequentially with working_dir(self.build_directory): - for target in ["libs", "netlib", "shared"]: - tty.info("Building target", target) - make(*(args + [target])) + # Due to the verbosity of the command line and number of object + # files created, we suppress makefile command echoing via `-s`. + make("-s", *self.make_defs) @run_after("build") @on_package_attributes(run_tests=True) From 7442fbdab49630a94c47f76eed6f2f1084afbe40 Mon Sep 17 00:00:00 2001 From: Harmen Stoppels Date: Wed, 29 Apr 2026 13:42:45 +0200 Subject: [PATCH 2/2] also remove incorrect import Signed-off-by: Harmen Stoppels --- repos/spack_repo/builtin/packages/openblas/package.py | 1 - 1 file changed, 1 deletion(-) diff --git a/repos/spack_repo/builtin/packages/openblas/package.py b/repos/spack_repo/builtin/packages/openblas/package.py index c173f738004..800ab8ce535 100644 --- a/repos/spack_repo/builtin/packages/openblas/package.py +++ b/repos/spack_repo/builtin/packages/openblas/package.py @@ -9,7 +9,6 @@ from spack_repo.builtin.build_systems.cmake import CMakePackage from spack_repo.builtin.build_systems.makefile import MakefilePackage -from spack.llnl.util import tty from spack.package import *