Conveniently disable auto tagging proposal#43

Open

jan888adams wants to merge 16 commits into

conveniently-disable-auto-taggingfrom

conveniently-disable-auto-tagging-proposal

Commits on Mar 1, 2026

Fix review findings: index, partial tags, empty tag call, tests, and @internal

Jan Adams
and
claude
committed
Fix review findings: encapsulation, style, and naming

Jan Adams
and
claude
committed
Revert getRecordedTags() — public property is idiomatic here

Jan Adams
and
claude
committed
Remove isEmpty() guard — FOSHttpCache already handles empty tag arrays

Jan Adams
and
claude
committed
Remove @internal from CacheType interface

Jan Adams
and
claude
committed
Use expectException and shouldNotBeCalled() instead of try/catch

Jan Adams
and
claude
committed
Remove redundant index counter from withoutAutomaticTagging error message

Jan Adams
and
claude
committed
Revert atomic tag accumulation — partial tags on invalid yield are intentional

Jan Adams
and
claude
committed
Fix incomplete rename: update all usages of collectTagsResponseTagger to traceableResponseTagger

Jan Adams
and
claude
committed
Re-add iteration counter as \$position to error message for invalid yield

Jan Adams
and
claude
committed
Rename \$yielded to \$value in withoutAutomaticTagging generator loop

Jan Adams
and
claude
committed
Make position counter 1-based by incrementing before the exception check

Jan Adams
and
claude
committed
Document withoutAutomaticTagging() in disable caching behavior doc

Jan Adams
and
claude
committed
Add integration tests for withoutAutomaticTagging()

Jan Adams
and
claude
committed
Fix review findings: trailing blank line, reserved keyword param name, int cast

Jan Adams
and
claude
committed

Commits on Mar 2, 2026

Revert $value to $yielded and position to index in withoutAutomaticTagging

Jan Adams
and
claude
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Conveniently disable auto tagging proposal#43

Conveniently disable auto tagging proposal#43
jan888adams wants to merge 16 commits into
conveniently-disable-auto-taggingfrom
conveniently-disable-auto-tagging-proposal

Commits on Mar 1, 2026

Fix review findings: index, partial tags, empty tag call, tests, and @internal

Fix review findings: encapsulation, style, and naming

Revert getRecordedTags() — public property is idiomatic here

Remove isEmpty() guard — FOSHttpCache already handles empty tag arrays

Remove @internal from CacheType interface

Use expectException and shouldNotBeCalled() instead of try/catch

Remove redundant index counter from withoutAutomaticTagging error message

Revert atomic tag accumulation — partial tags on invalid yield are intentional

Fix incomplete rename: update all usages of collectTagsResponseTagger to traceableResponseTagger

Re-add iteration counter as \$position to error message for invalid yield

Rename \$yielded to \$value in withoutAutomaticTagging generator loop

Make position counter 1-based by incrementing before the exception check

Document withoutAutomaticTagging() in disable caching behavior doc

Add integration tests for withoutAutomaticTagging()

Fix review findings: trailing blank line, reserved keyword param name, int cast

Commits on Mar 2, 2026

Revert $value to $yielded and position to index in withoutAutomaticTagging