Feat/mysql oracle image compatibility#11767
Closed
haider2122 wants to merge 1 commit intotestcontainers:mainfrom
Closed
Feat/mysql oracle image compatibility#11767haider2122 wants to merge 1 commit intotestcontainers:mainfrom
haider2122 wants to merge 1 commit intotestcontainers:mainfrom
Conversation
…rver image MySQLContainer now natively accepts the official Oracle MySQL image without requiring .asCompatibleSubstituteFor(mysql). According to MySQL documentation, container-registry.oracle.com/mysql/community-server is the official Docker image of MySQL, not the docker.io/mysql image. Closes testcontainers#9452
haider2122
force-pushed
the
feat/mysql-oracle-image-compatibility
branch
from
45ce1bc to
a0cba69
Compare
Member
|
I don't think we can add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
container-registry.oracle.com/mysql/community-serveras a nativelycompatible image name in
MySQLContainer.Why
Per MySQL's official documentation,
container-registry.oracle.com/mysql/community-serveris the officialDocker image of MySQL. The
docker.io/mysqlimage is not officially maintained by Oracle.Previously, users who wanted to use the official image had to use a workaround:
This change makes that unnecessary:
Changes
ORACLE_IMAGE_NAMEconstant toorg.testcontainers.mysql.MySQLContainerORACLE_IMAGE_NAMEconstant to deprecatedorg.testcontainers.containers.MySQLContainerassertCompatibleWithin both classes to accept the Oracle imageCloses #9452