fix: schematics fail with "exports is not defined in ES module scope" during ng update#585
Merged
Merged
Conversation
…onJS
The distributed package has "type": "module" (added by ng-packagr), which
causes Node.js to treat all .js files in the package as ES modules. The
schematics are compiled as CommonJS and use `exports`, so running ng-update
fails with "exports is not defined in ES module scope".
Adding a package.json with {"type": "commonjs"} in the schematics directory
tells Node.js to treat those .js files as CommonJS modules, fixing the error.
Copilot
AI
changed the title
[WIP] Fix unhandled exception during ng update to Angular 22
fix: schematics fail with "exports is not defined in ES module scope" during ng update
Jun 5, 2026
timdeschryver
approved these changes
Jun 5, 2026
|
🎉 This PR is included in version 19.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ng-packagrsets"type": "module"in the distributedpackage.json, causing Node.js to treat all.jsfiles in the package as ES modules. The schematics (used byng update) are compiled as CommonJS and useexports/require, which breaks under that ESM context.Changes
projects/testing-library/schematics/package.json— adds{"type": "commonjs"}to the schematics source directoryNode.js resolves module type from the nearest
package.json, so this override scopes CommonJS treatment to theschematics/subdirectory only. The file is picked up automatically by the existingng-package.jsonassets glob ("schematics/**/*.json") and lands atdist/@testing-library/angular/schematics/package.jsonin the published package.