From 48a0108e82970d7257feb4497d77ea0b7a500f00 Mon Sep 17 00:00:00 2001 From: Mustafa Mulla Date: Fri, 29 May 2026 23:16:12 +0530 Subject: [PATCH 1/2] Remove duplicate padding updation from Breakout.ts --- .../primitive-components/Breakout/Breakout.ts | 19 +- .../autoplaced-breakoutpoints1-pcb.snap.svg | 2 +- .../autoplaced-breakoutpoints2-pcb.snap.svg | 2 +- ...ader-and-passives-autorouting-srj.snap.svg | 249 +++++++------- ...fp16-with-header-and-passives-pcb.snap.svg | 2 +- ...ulator-power-rail-autorouting-srj.snap.svg | 314 +++++++++--------- ...ut-sot23-regulator-power-rail-pcb.snap.svg | 2 +- ...sor-to-i2c-header-autorouting-srj.snap.svg | 228 ++++++------- ...ut-soic8-sensor-to-i2c-header-pcb.snap.svg | 2 +- 9 files changed, 407 insertions(+), 413 deletions(-) diff --git a/lib/components/primitive-components/Breakout/Breakout.ts b/lib/components/primitive-components/Breakout/Breakout.ts index 52574c8e2..e0c796eab 100644 --- a/lib/components/primitive-components/Breakout/Breakout.ts +++ b/lib/components/primitive-components/Breakout/Breakout.ts @@ -102,24 +102,7 @@ export class Breakout extends Group { } } - doInitialPcbPrimitiveRender(): void { + doInitialPcbPrimitiveRender(): void { super.doInitialPcbPrimitiveRender() - if (this.root?.pcbDisabled) return - const { db } = this.root! - const props = this._parsedProps as z.infer - if (!this.pcb_group_id) return - const pcb_group = db.pcb_group.get(this.pcb_group_id)! - const padLeft = props.paddingLeft ?? props.padding ?? 0 - const padRight = props.paddingRight ?? props.padding ?? 0 - const padTop = props.paddingTop ?? props.padding ?? 0 - const padBottom = props.paddingBottom ?? props.padding ?? 0 - db.pcb_group.update(this.pcb_group_id, { - width: (pcb_group.width ?? 0) + padLeft + padRight, - height: (pcb_group.height ?? 0) + padTop + padBottom, - center: { - x: pcb_group.center.x + (padRight - padLeft) / 2, - y: pcb_group.center.y + (padTop - padBottom) / 2, - }, - }) } } diff --git a/tests/breakout/__snapshots__/autoplaced-breakoutpoints1-pcb.snap.svg b/tests/breakout/__snapshots__/autoplaced-breakoutpoints1-pcb.snap.svg index ca9816f65..c70c9b282 100644 --- a/tests/breakout/__snapshots__/autoplaced-breakoutpoints1-pcb.snap.svg +++ b/tests/breakout/__snapshots__/autoplaced-breakoutpoints1-pcb.snap.svg @@ -1 +1 @@ -R1C1R2 \ No newline at end of file +R1C1R2 \ No newline at end of file diff --git a/tests/breakout/__snapshots__/autoplaced-breakoutpoints2-pcb.snap.svg b/tests/breakout/__snapshots__/autoplaced-breakoutpoints2-pcb.snap.svg index a2d3f97f4..eeb3bd47a 100644 --- a/tests/breakout/__snapshots__/autoplaced-breakoutpoints2-pcb.snap.svg +++ b/tests/breakout/__snapshots__/autoplaced-breakoutpoints2-pcb.snap.svg @@ -1 +1 @@ -R1C1R2 \ No newline at end of file +R1C1R2 \ No newline at end of file diff --git a/tests/breakout/__snapshots__/breakout-qfp16-with-header-and-passives-autorouting-srj.snap.svg b/tests/breakout/__snapshots__/breakout-qfp16-with-header-and-passives-autorouting-srj.snap.svg index 245997948..5a1ec4dda 100644 --- a/tests/breakout/__snapshots__/breakout-qfp16-with-header-and-passives-autorouting-srj.snap.svg +++ b/tests/breakout/__snapshots__/breakout-qfp16-with-header-and-passives-autorouting-srj.snap.svg @@ -13,64 +13,63 @@ >FULL ROUTED CIRCUIT: 5 CONNECTIONS, 11 TRACES -