From 7e8931c3c2a8c58c3434d1949449242e28c9235c Mon Sep 17 00:00:00 2001 From: Dan Freeman Date: Mon, 21 Nov 2022 15:25:40 +0100 Subject: [PATCH 1/6] Drop `hbs` support in `ember-template-imports` --- .../-private/dsl/integration-declarations.d.ts | 5 ----- .../-private/environment/index.ts | 2 +- .../-private/environment/transform.ts | 2 +- 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/packages/environment-ember-template-imports/-private/dsl/integration-declarations.d.ts b/packages/environment-ember-template-imports/-private/dsl/integration-declarations.d.ts index 603ab19bb..979954531 100644 --- a/packages/environment-ember-template-imports/-private/dsl/integration-declarations.d.ts +++ b/packages/environment-ember-template-imports/-private/dsl/integration-declarations.d.ts @@ -31,8 +31,3 @@ type EELLinkTo = typeof Globals.LinkTo; declare module '@ember/routing' { export interface LinkTo extends EELLinkTo {} } - -import 'ember-template-imports'; -declare module 'ember-template-imports' { - export function hbs(contents: TemplateStringsArray): unknown; -} diff --git a/packages/environment-ember-template-imports/-private/environment/index.ts b/packages/environment-ember-template-imports/-private/environment/index.ts index cdb179191..735c9a7bc 100644 --- a/packages/environment-ember-template-imports/-private/environment/index.ts +++ b/packages/environment-ember-template-imports/-private/environment/index.ts @@ -14,7 +14,7 @@ export default function emberTemplateImportsEnvironment( return { tags: { - 'ember-template-imports': { + '@glint/environment-ember-template-imports/-private/tag': { hbs: { typesModule: '@glint/environment-ember-template-imports/-private/dsl', specialForms: { diff --git a/packages/environment-ember-template-imports/-private/environment/transform.ts b/packages/environment-ember-template-imports/-private/environment/transform.ts index 30178308a..feae6589c 100644 --- a/packages/environment-ember-template-imports/-private/environment/transform.ts +++ b/packages/environment-ember-template-imports/-private/environment/transform.ts @@ -94,7 +94,7 @@ function addTagImport(f: ts.NodeFactory, sourceFile: ts.SourceFile): ts.SourceFi f.createImportSpecifier(false, f.createIdentifier('hbs'), f.createIdentifier(GLOBAL_TAG)), ]) ), - f.createStringLiteral('ember-template-imports') + f.createStringLiteral('@glint/environment-ember-template-imports/-private/tag') ), ...sourceFile.statements, ]); From ce5a668fd134f84a4bd6e23999cac7f100e7d577 Mon Sep 17 00:00:00 2001 From: Dan Freeman Date: Mon, 21 Nov 2022 15:27:05 +0100 Subject: [PATCH 2/6] Stop using deprecated TS AST builders TypeScript had to rework a few bits of their AST in light of how decorators shook out for stage 3. --- .../-private/environment/transform.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/packages/environment-ember-template-imports/-private/environment/transform.ts b/packages/environment-ember-template-imports/-private/environment/transform.ts index feae6589c..b4bc6ede2 100644 --- a/packages/environment-ember-template-imports/-private/environment/transform.ts +++ b/packages/environment-ember-template-imports/-private/environment/transform.ts @@ -85,7 +85,6 @@ function repairAncestry(node: ts.Node, parent: ts.Node = node.parent): ts.Node { function addTagImport(f: ts.NodeFactory, sourceFile: ts.SourceFile): ts.SourceFile { return f.updateSourceFile(sourceFile, [ f.createImportDeclaration( - [], [], f.createImportClause( false, @@ -163,8 +162,6 @@ function buildStaticBlockForTemplate( template: ts.TaggedTemplateExpression ): ts.Node { return f.createClassStaticBlockDeclaration( - [], - [], f.createBlock([f.createExpressionStatement(template)]) ); } From 8aa5429e49348f7040fb391ae1b8eff266049ec5 Mon Sep 17 00:00:00 2001 From: Dan Freeman Date: Mon, 21 Nov 2022 17:09:58 +0100 Subject: [PATCH 3/6] Use `