[Bugfix] Reject sampling params unsupported by diffusion models#45418
Merged
Isotr0py merged 10 commits intoJul 7, 2026
Merged
Conversation
guan404ming
requested review from
Harry-Chen,
NickLucche,
khluu and
njhill
as code owners
guan404ming
force-pushed
the
fix/diffusion-gemma-sampling-param-warnings
branch
2 times, most recently
from
be4ce59 to
8f21396
Compare
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
guan404ming
force-pushed
the
fix/diffusion-gemma-sampling-param-warnings
branch
from
8f21396 to
35d9834
Compare
guan404ming
force-pushed
the
fix/diffusion-gemma-sampling-param-warnings
branch
2 times, most recently
from
5bb7246 to
3231a2d
Compare
Contributor
Author
|
Hi @Isotr0py please help take a look this one as well when you are available, thanks! |
guan404ming
force-pushed
the
fix/diffusion-gemma-sampling-param-warnings
branch
2 times, most recently
from
acae485 to
6d42987
Compare
guan404ming
force-pushed
the
fix/diffusion-gemma-sampling-param-warnings
branch
from
6d42987 to
ae9a661
Compare
Isotr0py
approved these changes
Jun 27, 2026
github-actions
Bot
added
the
ready
auto-merge was automatically disabled
June 29, 2026 02:06
Head branch was pushed to by a user without write access
guan404ming
force-pushed
the
fix/diffusion-gemma-sampling-param-warnings
branch
7 times, most recently
from
0e2bed5 to
4658993
Compare
guan404ming
force-pushed
the
fix/diffusion-gemma-sampling-param-warnings
branch
from
4658993 to
9072102
Compare
Contributor
Author
|
Hi @Isotr0py this one's ci looks great now, please help take another look. Thanks! |
Contributor
|
Hi @guan404ming, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, |
guan404ming
force-pushed
the
fix/diffusion-gemma-sampling-param-warnings
branch
from
0e05848 to
6552b3d
Compare
Contributor
|
Hi @guan404ming, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, |
Signed-off-by: Guan-Ming (Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
Signed-off-by: Guan-Ming (Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
guan404ming
force-pushed
the
fix/diffusion-gemma-sampling-param-warnings
branch
from
6552b3d to
3796a63
Compare
Contributor
Author
|
Thanks @Isotr0py very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Diffusion models ignore per-request sampling params
Related: #45163
Test Plan
pytest -v tests/test_sampling_params.py
Test Result
12 passed
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.