diff --git a/src/database.py b/src/database.py index bf092b6..1b9f31a 100755 --- a/src/database.py +++ b/src/database.py @@ -53,7 +53,26 @@ def run_download(): logger.info("[2/2] Extracting database...") with tarfile.open(download_file_path) as tarball: - tarball.extractall(default_database_path) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tarball, default_database_path) os.remove(download_file_path)