Skip to content

feat: add proper error handling #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hauserkristof wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: add proper error handling #20

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
56b140c
feat: add commits
hauserkristof May 15, 2025
e53ce79
chore: add biome, gitignore
hauserkristof Dec 6, 2024
ec6b882
fix(path-data-polyfill): format
hauserkristof May 14, 2025
03f52b0
fix(path-data-polyfill): lint
hauserkristof May 14, 2025
aa03575
feat: exclude alpine from biome config
hauserkristof May 14, 2025
a2b9b45
fix(web): lint, format
hauserkristof May 14, 2025
f7efd76
fix(web): line width format
hauserkristof May 14, 2025
1ab6473
fix(web): yak, undefined, null check
hauserkristof May 14, 2025
46ebc98
fix: literal keys
hauserkristof May 15, 2025
8ecbcbb
fix(web): lint, format
hauserkristof May 14, 2025
b068f51
feat(web): add error handling, resilience if no image data is present
hauserkristof May 14, 2025
9f21fe0
feat(web): add WASM init error handling
hauserkristof May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions web/scripts/libgingerbread.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,30 @@ export class LibGingerbread {
this.zig.exports.conversion_start();
}

conversion_add_raster_layer(layer, scale, image) {
conversion_add_raster_layer(layer, scale, imageData) {
if (!this.image_array_ptr) {
this.image_array_ptr = this.zig.allocate(image.data.byteLength);
this.image_array_ptr = this.zig.allocate(imageData.data.byteLength);
}

this.image_array_ptr.u8().set(image.data);
this.image_array_ptr.u8().set(imageData.data);

this.zig.exports.conversion_add_raster_layer(layer, scale, this.image_array_ptr.address, image.width, image.height);
try {
this.zig.exports.conversion_add_raster_layer(
layer,
scale,
this.image_array_ptr.address,
imageData.width,
imageData.height,
);
} catch (error) {
console.log("===================conversion_add_raster_layer error============================");
console.log("layer:", layer, "scale:", scale, "width:", imageData.width, "height:", imageData.height);
console.log("imageData:", imageData);
console.log("image_array_ptr:", this.image_array_ptr);
console.error("WASM error in conversion_add_raster_layer:", error);
console.log("================================================");
throw error;
}
}

conversion_finish() {
Expand Down
68 changes: 61 additions & 7 deletions web/scripts/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,11 @@ class Design {

cvs.clear();

if (this.preview_layout === "front" || this.preview_layout === "front-spread" || this.preview_layout === "both") {
if (
this.preview_layout === "front" ||
this.preview_layout === "front-spread" ||
this.preview_layout === "both"
) {
await this.draw_layers(["EdgeCuts", "FCu", "FMask", "FSilkS", "Drill"], "left");
}

Expand All @@ -244,6 +248,10 @@ class Design {

async export(method) {
const gingerbread = await LibGingerbread.new();
gingerbread.onRuntimeError = (error) => {
console.error("WASM Runtime Error:", error);
console.error("Stack trace:", error.stack);
};
console.log(gingerbread);

gingerbread.conversion_start();
Expand All @@ -253,10 +261,29 @@ class Design {
case "raster": {
const bm = await layer.get_raster_bitmap();
const imgdata = await yak.ImageData_from_ImageBitmap(bm);
gingerbread.conversion_add_raster_layer(layer.number, this.trace_scale_factor, imgdata);

// Check that the ImageData is valid
const imgdata_sum = imgdata.data.reduce((a, b) => a + b, 0);
Copy link
Copy Markdown
Collaborator

@theacodes theacodes Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be 0 for an all black image, which would still be a valid, if silly, image. Would it be better to check if the length is 0?

Copy link
Copy Markdown
Contributor Author

@hauserkristof hauserkristof Jul 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe, I will test it tomorrow!

I had problems with all black images previously, so I had to add this, but maybe checking for length is enough


if (imgdata_sum === 0) {
console.log("Skipping layer:", layer.name, "because it has no data");
continue;
}

try {
gingerbread.conversion_add_raster_layer(layer.number, this.trace_scale_factor, imgdata);
} catch (error) {
console.log("imgdata:", imgdata);
console.error("WASM error in conversion_add_raster_layer:", error, {
layer: layer.name,
number: layer.number,
scale_factor: this.trace_scale_factor,
});
// throw error;
}
break;
}
case "vector":
case "vector": {
for (const path of layer.get_paths()) {
gingerbread.conversion_start_poly();
for (const pt of path) {
Expand All @@ -265,16 +292,25 @@ class Design {
gingerbread.conversion_end_poly(layer.number, 1, false);
}
break;
case "drill":
}
case "drill": {
for (const circle of layer.get_circles()) {
gingerbread.conversion_add_drill(circle.cx.baseVal.value, circle.cy.baseVal.value, circle.r.baseVal.value * 2, this.dpmm);
gingerbread.conversion_add_drill(
circle.cx.baseVal.value,
circle.cy.baseVal.value,
circle.r.baseVal.value * 2,
this.dpmm,
);
}
break;
default:
}
default: {
throw `Unexpected layer type ${layer.type}`;
}
}
}

console.log("Conversion finished");
const footprint = gingerbread.conversion_finish();

if (method === "clipboard") {
Expand Down Expand Up @@ -324,7 +360,11 @@ class Layer {
if (!this.bitmap) {
this.bitmap = await yak.createImageBitmap(this.svg, this.design.constructor.preview_width);
if (this.is_mask) {
this.bitmap = await yak.ImageBitmap_inverse_mask(this.bitmap, await this.design.edge_cuts.get_preview_bitmap(), this.color);
this.bitmap = await yak.ImageBitmap_inverse_mask(
this.bitmap,
await this.design.edge_cuts.get_preview_bitmap(),
this.color,
);
}
}
return this.bitmap;
Expand Down Expand Up @@ -400,3 +440,17 @@ document.addEventListener("alpine:init", () => {
},
}));
});

LibGingerbread.onRuntimeError = (error) => {
console.error("WASM Runtime Error:", error);
console.error("Stack trace:", error.stack);

if (error?.message?.includes("unreachable")) {
console.error("WASM hit unreachable code - this likely means a panic occurred");
console.error("Last known operation:", LibGingerbread.lastOperation);
} else if (error.message) {
console.error("WASM error- this is probably a bug in the Gingerbread code");
} else {
throw new Error(`WASM execution failed: ${error.message}`);
}
};