BREAKING CHANGE: do not allow simple requests for login#4823
Merged
Conversation
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
github-actions
Bot
added
the
Sensitive
Contributor
|
This may qualify as a breaking change as well. I remember having to do some custom logic in the login controller to keep the behaviour the same as before. |
…_ATTR. Using defaultIfEmpty (rather than switchIfEmpty) guarantees the chain is filtered exactly once. chain.filter(...) returns Mono<Void>, which completes without emitting a value, so a switchIfEmpty placed after it would always fire its fallback and invoke the downstream chain (and the controller) a second time. Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
achmelo
changed the title
Signed-off-by: ac892247 <a.chmelo@gmail.com>
taban03
reviewed
Jul 23, 2026
taban03
reviewed
Jul 23, 2026
taban03
reviewed
Jul 23, 2026
taban03
reviewed
Jul 23, 2026
taban03
reviewed
Jul 23, 2026
Co-authored-by: Andrea Tabone <39694626+taban03@users.noreply.github.com> Signed-off-by: achmelo <37397715+achmelo@users.noreply.github.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
# Conflicts: # apiml/src/main/java/org/zowe/apiml/WebSecurityConfig.java
Signed-off-by: ac892247 <a.chmelo@gmail.com>
taban03
approved these changes
Jul 24, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Require content-type=application/json for login request. Respond with 415 in case of other content types.
Linked to # (issue)
Part of the # (epic)
Type of change
Checklist:
For more details about how should the code look like read the Contributing guideline