fix: infinispan store migrator#4827
Draft
taban03 wants to merge 10 commits into
Draft
Conversation
…e the distributed caches Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
taban03
marked this pull request as draft
July 20, 2026 15:41
| log.info("Attempting migration of legacy store for cache {} at {}", cacheName, cacheDir); | ||
| try { | ||
| // clear any leftover from a previous failed attempt so the migrator starts from an empty target | ||
| deleteRecursively(migratedDir); |
Contributor
There was a problem hiding this comment.
Please move this to finally, there should be clean up. So only backup and the main folder should remain.
| * permissions, etc.) would not be fixed by migrating the store, so it's not worth attempting. | ||
| */ | ||
| static boolean isLegacyStoreFailure(Throwable t) { | ||
| for (Throwable cause = t; cause != null; cause = cause.getCause()) { |
Contributor
There was a problem hiding this comment.
Be aware on setting itself as the cause. You can rather use Apache tool ExceptionUtils.
| return false; | ||
| } | ||
|
|
||
| static void deleteRecursively(Path dir) throws IOException { |
Contributor
There was a problem hiding this comment.
Apache IO common utility? FileUtils.deleteDirectory( file );
| import org.infinispan.tools.store.migrator.StoreMigrator; | ||
|
|
||
| @Slf4j | ||
| public class Main { |
Contributor
There was a problem hiding this comment.
Isn't more helpful to create a script instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Linked to # (issue)
Part of the # (epic)
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline