Skip to content

docs: update stale miden-vm version in dependency diagram#190

Open
amathxbt wants to merge 4 commits into0xMiden:mainfrom
amathxbt:patch-1
Open

docs: update stale miden-vm version in dependency diagram#190
amathxbt wants to merge 4 commits into0xMiden:mainfrom
amathxbt:patch-1

Conversation

@amathxbt
Copy link
Copy Markdown

@amathxbt amathxbt commented Mar 5, 2026

The dependency diagram references miden-vm v0.19.1 but the release manifest example and latest release is v0.20.0. Updated for consistency.

AMATH added 2 commits March 5, 2026 22:04
The dependency diagram references miden-vm v0.19.1 but the release manifest example and latest release is v0.20.0. Updated for consistency.
@Keinberger
Copy link
Copy Markdown
Collaborator

Hey @amathxbt, thanks for catching the stale versions in the diagram!

The version labels in the diagram refer to what cut-versions.yml used for the last versioned snapshot. Those values come from .release/release-manifest.yml, which currently has different versions than what your PR proposes (e.g. miden-vm is at v0.20.6 in the manifest, not v0.20.0). The other three repos (miden-base, miden-node, miden-client) are also outdated in the diagram.

I think the better fix here is to replace the specific version tags in the diagram with something generic like @<release-tag>, so the README doesn't go stale every time we cut a new version. We can add a note pointing to .release/release-manifest.yml as the source of truth for the actual pinned refs.

Would you be up for making that change? Let me know if you have questions about how the versioning works!

Thanks!

@amathxbt

This comment was marked as spam.

Copy link
Copy Markdown
Author

@amathxbt amathxbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification! I've updated the diagram to use "" instead of fixed versions for the CutVersions workflow.

@BrianSeong99
Copy link
Copy Markdown
Contributor

Thanks for flagging the stale versions. Replacing them with placeholders loses useful information though, and the diff has indentation issues that would break the Mermaid rendering. Closing this — we'll address the stale versions separately.

@amathxbt

This comment was marked as spam.

@BrianSeong99
Copy link
Copy Markdown
Contributor

BrianSeong99 commented Mar 22, 2026

I was closing different PRs claude coded the wrong PR, apologies, I'll review this and merge this today after testing it locally

@BrianSeong99 BrianSeong99 reopened this Mar 22, 2026
@amathxbt

This comment was marked as spam.

@BrianSeong99
Copy link
Copy Markdown
Contributor

BrianSeong99 commented Mar 22, 2026 via email

@amathxbt

This comment was marked as spam.

@amathxbt

This comment was marked as spam.

@amathxbt

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants