feat: Add Send + Sync supertraits and add Send to futures return by dyn-compatible traits#926
Merged
Merged
Conversation
Contributor
Author
|
Can confirm that these changes fix the Send/Sync issue that blocked me from integrating the TonicRpcClient to this project |
tomyrd
force-pushed
the
tomyrd-send-sync-rpc-with-test
branch
2 times, most recently
from
2f2dde0 to
2d1fe58
Compare
Contributor
|
I'm sorry @sergerad. I didn't notice that you had added commits to this branch and just force pushed to it. Could you please check again that the branch works with your |
tomyrd
added
the
no docs
Contributor
Author
Thanks I have pushed up my changes now. Was just a bit of cleanup around the tests. |
sergerad
changed the title
sergerad
changed the title
sergerad
force-pushed
the
tomyrd-send-sync-rpc-with-test
branch
from
c4ccfff to
87df3e2
Compare
tomyrd
approved these changes
May 28, 2025
Contributor
Author
igamigo
approved these changes
May 30, 2025
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Relates to #849. Following on from this we could make the overall
Clientstruct Sync with Send futures too.In the past it has been impossible to use
TonicRpcClientin a tokio task across await points because the futures returned by its implementation ofNodeRpcClientwere notSend.Also the miden-client contains instances of
Box<dyn NodeRpcClient + Send>. Because these trait objects are notSync, their futures cannot beSend.Changes
TonicRpcClientandStoretraits to be subtraits ofSendandSync.TonicRpcClientandStoretrait functions to return futures which areSend.