Skip to content

Test timings and effect of enabling avx2 - #538

Open
robknight wants to merge 5 commits into
mainfrom
test-timings
Open

Test timings and effect of enabling avx2#538
robknight wants to merge 5 commits into
mainfrom
test-timings

Conversation

@robknight

@robknight robknight commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Enable mimalloc and avx2 in CI, which results in ~13% faster proofs, and therefore faster tests.

Also adds some code for retrieving more detailed timing information from proofs, which is behind an existing feature flag, and configuration for enabling this in a CI workflow (off by default).

@robknight
robknight requested a review from ed255 August 19, 2026 15:14

@ed255 ed255 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

other = parse(f)
if not base or not other:
sys.exit("no timing lines found in one of the logs")
compare(base, other, "base", "avx2")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
compare(base, other, "base", "avx2")
compare(base, other, "base", "other")

I think this is supposed to be generic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants