miner: disable tracer in vm.Config to prevent conflicts during block synchronization#2206
miner: disable tracer in vm.Config to prevent conflicts during block synchronization#2206maoueh wants to merge 2 commits into0xPolygon:developfrom
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR prevents mining-time EVM execution from invoking the chain-level vm.Config.Tracer hooks, avoiding conflicts when “live tracing” is enabled during block synchronization.
Changes:
- In
miner/worker.go, explicitly clearsvm.Config.Tracerin the miner’s derived VM config to ensure tracing hooks don’t run during block production.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // in which should be active only for live tracing and no for mining. So here, we explicitly | ||
| // sets the tracer to nil to avoid having the miner tracing a block while it's produced conflicting | ||
| // with the live tracing. | ||
| cfg.Tracer = nil |
There was a problem hiding this comment.
This change alters miner EVM behavior when the chain VM config has a tracer set, but there’s no regression test to ensure the worker always strips the tracer from its vm.Config. Please add a unit test in miner/worker_test.go that sets a non-nil tracer on backend.chain.GetVMConfig(), calls w.vmConfig(), and asserts the returned config has Tracer == nil (and ideally that the chain’s VM config tracer remains unchanged).
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| cfg := *w.chain.GetVMConfig() | ||
| // The miner copies its vm.Config from the chain instance, which may include | ||
| // a vm.Config.Tracer intended only for live tracing, not for mining. Clear | ||
| // the tracer here to prevent the miner from tracing block production and | ||
| // conflicting with live tracing. | ||
| cfg.Tracer = nil | ||
|
|
There was a problem hiding this comment.
Consider adding a unit test to lock in this behavior: when the underlying chain VM config has a non-nil Tracer (e.g., from the VMTrace/live tracing flag), worker.vmConfig() should return a config with Tracer cleared. This prevents regressions where mining accidentally reuses the live tracer again.
Description
If running
borwith live tracing enabled, once reaching live, miner starts to also call the live tracing hooks causing problems because only the block synchronization should call the live tracer.Changes
Breaking changes
None
Nodes audience
People running Live Tracing + bor
Testing