Harden model-spec dependency option cross-checks - #161
Conversation
|
@lapy Is this PR ready for review? The test plan lists CI unit tests for the model-spec schema, but that item still appears incomplete. |
081c9e5 to
6fe5123
Compare
|
Yes — ready for review now. Updates since your comment:
Test-plan checkboxes are updated. |
|
CI came back cancelled (no runner / empty steps) after I added a Linux workflow change to run I’ve reverted the |
Require dependencies[].option and required_when.option_key to reference declared options, document OR semantics, and keep the toy demo in sync.
0a73c0e to
b0ee4b6
Compare
|
@lapy Merged. Thanks! |
Summary
dependencies[].optionto exist underoptions.<scope>required_when[].option_keyto refer to a declared option in that condition scope (public key form)required_whenrowsmainFollow-up from the discussion on #89. Keeps top-level
dependenciesseparate from options; this only hardens the schema gate.Test plan
model_spec_system_testpasses locally (covers undeclareddependencies[].option/required_when.option_key)model_specs/*.jsonsatisfy the new dependency/option cross-checks