Add Irodori codec backend selection - #189
Open
0xShug0 wants to merge 1 commit into
Open
Conversation
Owner
Author
|
@francescobozzo @fedeizzo It’s weird that this model-scoped change failed the Nix/Vulkan CI. Any thoughts on what might be causing this? |
Contributor
|
Interesting, the build "worked on my machine"... I tested using my nix system installation and also reproducing github workflows with containers git clone git@github.com:0xShug0/audio.cpp.git audio.cpp-remote
cd audio.cpp-remote
gh pr checkout 189
nix build .#vulkan
nix run nixpkgs#act -- -W .github/workflows/nix-build.yml |
Owner
Author
|
@francescobozzo Retry works. “Have you tried turning it off and on again?” I should’ve followed this golden rule 😄 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
irodori_tts.codec_backend=same|cpuas an Irodori-only session optionValidation
cmake --build build/debug -j 16 --target audiocpp_cliirodori_tts.codec.backend same--session-option irodori_tts.codec_backend=cpulogsirodori_tts.codec.backend cpuand produces valid audioInvalid irodori_tts.codec_backend: bad