Skip to content

chore: remove unmaintained daemonize crate (RUSTSEC-2025-0069) #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jeshua Ben Joseph (Theaxiom) merged 2 commits into from
Apr 16, 2026
Merged

chore: remove unmaintained daemonize crate (RUSTSEC-2025-0069) #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e45617
Initial plan
Copilot Apr 6, 2026
52ce3c7
chore: remove unmaintained daemonize crate (RUSTSEC-2025-0069)
Copilot Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ prost = { workspace = true }

# Platform-specific daemon support
[target.'cfg(unix)'.dependencies]
daemonize = "0.5"
libc = "0.2"
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since CI and release workflows run Cargo with --locked, removing daemonize from this manifest also requires committing the regenerated Cargo.lock. The current lockfile still lists daemonize as a dependency of the aegis-orchestrator package, which will cause cargo * --locked to fail until the lockfile is updated.

Suggested change
libc = "0.2"
libc = "0.2"
daemonize = "0.5"

Copilot uses AI. Check for mistakes.

[package.metadata.docs.rs]
Expand Down
11 changes: 0 additions & 11 deletions cli/src/daemon/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,17 +166,6 @@ fn temporal_connection_max_retries(raw_value: Option<i32>) -> i32 {
// cluster_status_view, load_cluster_nodes moved to cluster_helpers.rs

pub async fn start_daemon(config_path: Option<PathBuf>, port: u16) -> Result<()> {
// Daemonize on Unix
// NOTE: We skip internal daemonization because calling fork() (via daemonize)
// inside a Tokio runtime (#[tokio::main]) breaks the reactor.
// The CLI 'daemon start' command already spawns this process as a detached background child.
/*
#[cfg(unix)]
{
daemonize_process()?;
}
*/

// Write PID file
let pid = std::process::id();
write_pid_file(pid)?;
Expand Down
Loading