Skip to content

Fix macOS fixed-mode ghost-frame from stale back-buffer content #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aHooder merged 3 commits into from
Jul 29, 2026
Merged

Fix macOS fixed-mode ghost-frame from stale back-buffer content #1148

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
835c48c
Clear the default framebuffer before compositing
nathan-scheele Jul 27, 2026
ee4c005
Merge remote-tracking branch 'upstream/master' into pr1148
aHooder Jul 29, 2026
4019377
Rework this slightly
aHooder Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/main/java/rs117/hd/renderer/zone/ZoneRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
import static net.runelite.api.Perspective.*;
import static org.lwjgl.opengl.GL33C.*;
import static org.lwjgl.opengl.GL40.GL_DRAW_INDIRECT_BUFFER;
import static rs117.hd.HdPlugin.APPLE;
import static rs117.hd.HdPlugin.COLOR_FILTER_FADE_DURATION;
import static rs117.hd.HdPlugin.NEAR_PLANE;
import static rs117.hd.HdPlugin.ORTHOGRAPHIC_ZOOM;
Expand Down Expand Up @@ -1149,6 +1150,15 @@ public void draw(int overlayColor) {

// Blit from the resolved FBO to the default FBO
glBindFramebuffer(GL_DRAW_FRAMEBUFFER, plugin.awtContext.getFramebuffer(false));

if (APPLE && !client.isResized()) {
// On macOS, we need to ensure that the alpha channel is opaque to prevent whatever
// is beneath from leaking through. In fixed mode, the MSAA resolve alone is not
// sufficient, since the viewport only covers part of the screen.
glClearColor(0, 0, 0, 1);
glClear(GL_COLOR_BUFFER_BIT);
}

glBlitFramebuffer(
0,
0,
Expand Down