docs: clarify contribution starting point - #4218
Conversation
| return `${person.first_name} ${person.last_name}` | ||
|
|
||
| } | ||
| return `${person.first_name} ${person.last_name}`; |
There was a problem hiding this comment.
'template literal syntax' is only available in ES6 (use 'esversion: 6').
| return maybePerson | ||
| } | ||
| const findPerson = (id) => ({ | ||
| id, |
There was a problem hiding this comment.
'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| } | ||
| return maybePerson | ||
| } | ||
| const findPerson = (id) => ({ |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| const { parse } = require('csv-parse/sync'); /* eslint-disable-line import/no-unresolved */ | ||
| const titleizeSlug = (id) => id | ||
| .split('-') | ||
| .map((part) => part.charAt(0).toUpperCase() + part.slice(1)) |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
| @@ -1,30 +1,23 @@ | |||
| const fs = require('fs'); | |||
| const { parse } = require('csv-parse/sync'); /* eslint-disable-line import/no-unresolved */ | |||
| const titleizeSlug = (id) => id | |||
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
65fb77f to
9730a65
Compare
| module.exports = async (slug) => { | ||
| const name = fullName(findPerson(slug)) | ||
| return `<a href="/author/${slug.toLowerCase()}/" itemprop="name">${name}</a>` | ||
| return `<span itemprop="name">${name}</span>` |
There was a problem hiding this comment.
'template literal syntax' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
Unrecoverable syntax error. (71% scanned).
| module.exports = async (slug) => { | ||
| const name = fullName(findPerson(slug)) | ||
| return `<a href="/author/${slug.toLowerCase()}/" itemprop="name">${name}</a>` | ||
| return `<span itemprop="name">${name}</span>` |
There was a problem hiding this comment.
'template literal syntax' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
Unrecoverable syntax error. (71% scanned).
| describe('teamLink filter', () => { | ||
| it('returns the team member name without linking to missing author pages', async () => { | ||
| expect(await teamLink('melody')).to.equal('<span itemprop="name">Melody</span>') | ||
| }) |
There was a problem hiding this comment.
Missing semicolon.
Unrecoverable syntax error. (83% scanned).
|
|
||
| describe('teamLink filter', () => { | ||
| it('returns the team member name without linking to missing author pages', async () => { | ||
| expect(await teamLink('melody')).to.equal('<span itemprop="name">Melody</span>') |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
Expected ')' and instead saw 'teamLink'.
Expected ')' to match '{' from line 8 and instead saw '('.
Expected an assignment or function call and instead saw an expression.
Expected an identifier and instead saw ')'.
Expected an operator and instead saw '.'.
Missing semicolon.
| const teamLink = require('../../../config/filters/teamLink') | ||
|
|
||
| describe('teamLink filter', () => { | ||
| it('returns the team member name without linking to missing author pages', async () => { |
|
|
||
| const teamLink = require('../../../config/filters/teamLink') | ||
|
|
||
| describe('teamLink filter', () => { |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
|
|
||
| const { expect } = chai | ||
|
|
||
| const teamLink = require('../../../config/filters/teamLink') |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.
| @@ -0,0 +1,11 @@ | |||
| const chai = require('chai') | |||
|
|
|||
| const { expect } = chai | |||
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.
| @@ -0,0 +1,11 @@ | |||
| const chai = require('chai') | |||
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.
9730a65 to
ca0af95
Compare
2 participants
Summary
data/team_members.csvno longer exists, and avoid generating links to missing author pagesFixes #3821
Testing