WIP: Йода-синтаксис. Fix #291#297
Closed
atai wants to merge 8 commits into
Closed
Conversation
added 7 commits
August 1, 2019 09:25
… аст и как по нему бегать и проверять.
Member
|
У нас же теперь естьlVal! Или как его там, и диагностику можно сделать нормально, без регулярки! |
Member
|
lValue - это про ассайнмент. а здесь экспрешен внутри условия, не? |
Member
Угу, я тупой =( |
theshadowco
reviewed
Nov 6, 2019
| * Annotation Processors | ||
| * Enable annotation processing - checked | ||
|
|
||
| ## Добавление диагностики |
Member
There was a problem hiding this comment.
Это лишнее, есть отдельный раздел с документацией
| Сравнивая значения и переменные помни: переменные слева быть должны (С) Yoda | ||
|
|
||
| Плохо: | ||
| ```BSL |
Member
There was a problem hiding this comment.
Описание стоит скорректировать по шаблону
Member
There was a problem hiding this comment.
и файлы переименовать по шаблону
Member
There was a problem hiding this comment.
оно начиналось еще в августе. тут многое уже надо дотянуть до шаблона :)
| scope = DiagnosticScope.BSL, | ||
| severity = DiagnosticSeverity.MINOR, | ||
| minutesToFix = 2 | ||
| ) |
| @@ -1,5 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <project version="4"> | |||
| <component name="JavaScriptSettings"> | |||
Member
|
Я попробую дотянуть. |
Member
|
Не хватило прав на форспуш. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Даигностика не проходит тест. Не могу понять, толи диапазон не правильный толи ошибка в коде. Как делать отладку не понял.
В комит попали файлы настроек, не понял почему.
.gitignor немного упорядочил.