Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces static AWS_ACCESS_KEY_ID / AWS_SECRET_ACCESS_KEY GitHub secrets
with OIDC role assumption across all three workflows. This is more secure
as it eliminates long-lived AWS credentials stored as GitHub secrets.
Changes
main-CI.yml— switched to OIDC authmain-deploy-dev.yml— switched to OIDC authmain-deploy.yml— switched to OIDC authconfigure-aws-credentialsv1 → v4 (required for OIDC)permissions: id-token: writeblock (required for GitHub to issue OIDC token)Testing
unrelated to this change)
After this is merged
The following repo secrets can be deleted by an admin if this key is not used anywhere else within the repository:
AWS_ACCESS_KEY_IDAWS_SECRET_ACCESS_KEYAWS_OIDC_ROLE_ARNmust remain.NOTES
The Elasticsearch ConnectTimeout seen in CI is a pre-existing issue unrelated
to this change. Ran into AccessDenied issues which I fixed via the IAM Role Permissions but this ConnectTimeout should be unrelated and investigated separately.