Greater compatibility for *BSD#1425
Open
chilledfrogs wants to merge 1 commit into9001:hovudstraumfrom
Open
Conversation
There are references to lsblk (from util-linux) and /proc that don't exist on *BSD, so this expands on some macOS-specific code to compensate for that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are references to
lsblk(from util-linux) and /proc that don't exist on *BSD, so this expands on some macOS-specific code to compensate for thatI did my best to follow the existing style and structure of the code, however I might have missed something (and also given that
_extdevs_nix()doesn't show IPv6 addresses by default that might need to be reworked in the future anyway)Testing from OpenBSD and FreeBSD users more than welcome, I have thus far tested this briefly on my OpenBSD box
This also lays better groundwork for packaging on OpenBSD and FreeBSD which I will get to afterwards
This PR complies with the DCO; https://developercertificate.org/