Add accountability#846
Open
thomash-acinq wants to merge 2 commits intomasterfrom
Open
Conversation
Add support for accountability to fight channel jamming: - We create accountable invoices (Bolt11 and Bolt12) - We set `upgrade_accountability` in HTLCs when paying accountable invoices Because we do not relay HTLCs, we don't need to set or read `accountable` in HTLCs. So this is not implemented.
thomash-acinq
force-pushed
the
accountability
branch
from
eceffe3 to
2bb5163
Compare
t-bast
reviewed
Jan 6, 2026
Member
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
Looks good, can you add unit tests for encoding/decoding each TLV added, which we can compare to eclair to catch potential encoding issues before releasing?
thomash-acinq
added a commit
to ACINQ/eclair
that referenced
this pull request
Jan 8, 2026
These tests are also added to lightning-kmp (ACINQ/lightning-kmp#846) to check compatibility.
Contributor
Author
|
Added some tests, also to eclair (ACINQ/eclair#3240) |
thomash-acinq
added a commit
to ACINQ/eclair
that referenced
this pull request
Jan 8, 2026
These tests are also added to lightning-kmp (ACINQ/lightning-kmp#846) to check compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for accountability to fight channel jamming:
upgrade_accountabilityin HTLCs when paying accountable invoicesBecause we do not relay HTLCs, we don't need to set or read
accountablein HTLCs. So this is not implemented.Eclair: ACINQ/eclair#3217
Spec: lightning/bolts#1280