Skip to content

fix: close cipher selection bar when selected items no longer exist#1481

Open
tmsjngx0 wants to merge 3 commits into
AChep:masterfrom
tmsjngx0:fix/selection-bar-stale
Open

fix: close cipher selection bar when selected items no longer exist#1481
tmsjngx0 wants to merge 3 commits into
AChep:masterfrom
tmsjngx0:fix/selection-bar-stale

Conversation

@tmsjngx0

@tmsjngx0 tmsjngx0 commented Jul 3, 2026

Copy link
Copy Markdown

Fixes #1473.

Problem: After deleting, trashing, archiving or merging all selected items, the selection bar stays open showing "0 selected". The bar's visibility was keyed off the raw selected-id set, while the displayed count was computed from ids filtered against still-existing ciphers — so stale ids kept the bar open.

Fix (3 commits):

  • Key the selection bar's empty-check off the filtered list of still-existing ciphers, so the bar closes itself once the selected ciphers are gone (shared createCipherSelectionFlow, affects vault list + duplicates).
  • Automatically drop deleted cipher IDs from the selection handle on the duplicates screen.
  • Automatically drop selected items from the selection when they are trashed or archived on the vault list.

Tested on desktop: select items → trash/merge all → selection bar now closes instead of lingering with "0 selected".

tmsjngx0 added 3 commits June 23, 2026 11:06
The selection bar visibility was keyed off the raw selected-id set while the
displayed count was computed from ids filtered against still-existing ciphers.
After a delete/merge removed the items, the stale ids kept the bar open showing
"0 selected". Key the empty-check off the filtered list so the bar closes
itself once the selected ciphers are gone. Affects vault list + duplicates
(shared createCipherSelectionFlow).
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@tmsjngx0

tmsjngx0 commented Jul 3, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@tmsjngx0

tmsjngx0 commented Jul 3, 2026

Copy link
Copy Markdown
Author

recheck

github-actions Bot added a commit that referenced this pull request Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Selection bar stays open showing "0 selected" after deleting/merging all selected items

1 participant