fix: close cipher selection bar when selected items no longer exist#1481
Open
tmsjngx0 wants to merge 3 commits into
Open
fix: close cipher selection bar when selected items no longer exist#1481tmsjngx0 wants to merge 3 commits into
tmsjngx0 wants to merge 3 commits into
Conversation
The selection bar visibility was keyed off the raw selected-id set while the displayed count was computed from ids filtered against still-existing ciphers. After a delete/merge removed the items, the stale ids kept the bar open showing "0 selected". Key the empty-check off the filtered list so the bar closes itself once the selected ciphers are gone. Affects vault list + duplicates (shared createCipherSelectionFlow).
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1473.
Problem: After deleting, trashing, archiving or merging all selected items, the selection bar stays open showing "0 selected". The bar's visibility was keyed off the raw selected-id set, while the displayed count was computed from ids filtered against still-existing ciphers — so stale ids kept the bar open.
Fix (3 commits):
createCipherSelectionFlow, affects vault list + duplicates).Tested on desktop: select items → trash/merge all → selection bar now closes instead of lingering with "0 selected".