Add Wireless Universal Terminal#88
Conversation
Port from EC2/AEAdditions
AE2FC dependence update
|
you'll have to update AE2FCR in dependencies.gradle btw. 332d525 said it's updating it but it's not actually up there. Also, tried it out a little bit, main feature functioning perfectly but:
|
I will consider updating the Tooltip based on your suggestion. To be honest, I am not very satisfied with the current "current mode" identification method. As for the mode switching update, I don’t know how to implement it yet. about crashes. AE2FCR can also cause crashes when it is not installed, I'm troubled by this Regarding the extension terminal, it cannot be realized because there is no wireless terminal. I need to provide it in AE2 first |
|
@zeng-github01 listen bruv this thing is SO fked up LMAO. you have to fix this ASAP bc it now allows you to get ANY items in game for free long as you have a universal terminal with Pattern and Crafting mode. to reproduce:
Simple as that. |
This is a compatibility issue. It may be caused by the closeness of Pattern and Crafting's Container. This is in a sense unfixable unless you can temporarily disable these slots in some way. This may be the reason why the original universal terminal does not support the installation of Pattern. Because the GUI comes directly from the AE2 code, it cannot be modified by some simple way. Unless a method similar to Mixin is used |
|
@ChromaPIE I figured out a possible solution. Will fix this in the future |
|
@NotMyWing The quickest way to fix this is to change the NBT Tag Name. Both Pattern and Crafting use "crafting Grid" as the Tag Name. This causes this problem I will submit a PR in AE2UEL to fix this issue. |
|
@ChromaPIE Fixed |
|
@ChromaPIE I can't find the cause of the crash caused by Mekeng and AE2FC not being installed, so I can't fix this problem for now. I have only fixed the problem that caused the item duplication. Finally, I chose to use Mixin to fix it directly instead of modifying AE2UEL. |
i dont know if it will be of some help or not but you can have a look at https://github.com/ChromaPIE/NAE2/tree/for-build-2, in this branch I brutally deleted stuff in ChromaPIE@1f6114f and the other two commits after this that might be related to MekEng (but not FCR bc i got that mod so i need the compat) and it's built and working. We might have to wait a little longer for Neeve's complete comeback. btw, problem fixed, awesome! but still, about my suggestions of improving this, you can leave the rest for the future except: a new keybind to open the terminal. it wont make sense if it's able to put it inside bauble slot but no way to use it besides taking it out. but that brings a new headache too: how to cycle through the modes when it's in bauble? |
|
@ChromaPIE Regarding the bauble issue, my attitude is that this is just a lazy approach. Because the wireless terminal has a base class, it defaults to making the item can be put into bauble, I don't really plan to support it for the time being. It's just because this base class can save some code... LOL |
|
understandable. might as well just remove the bauble support from it |
|
@ChromaPIE I'm thinking about porting fluid filler from EC to AE2FC, but there is no suitable texture. Do you think it should be ported? It is not often used, but it is a pity to delete it. |
|
personally i don't think that's necessary |
|
@ChromaPIE Fixed conversion bug when upgrading to universal terminal |
…w wireless terminal
…-port # Conflicts: # src/main/java/co/neeve/nae2/common/containers/ContainerPatternMultiTool.java # src/main/java/co/neeve/nae2/common/net/messages/PatternMultiToolPacket.java
|
@NotMyWing This PR may have to be abandoned. No matter how hard I try, I can't solve the mandatory dependency on MekEng or AE2FC. sad |
|
NO nah neeve please rescue this pr 😭🙏🏼 |
Due to force majeure, I plan to keep this branch and keep the items of this PR by syncing the master patch. You use it by yourself. |
|
Since the issue of hard dependency on MekEng has been fixed in #102, this PR is being reopened. |
# Conflicts: # src/main/java/co/neeve/nae2/common/registration/definitions/Items.java # src/main/resources/assets/nae2/lang/zh_cn.lang
|
@NotMyWing @IntegerLimit Existing PRs have been merged and conflicts resolved. @ChromaPIE Although a long time has passed, it is finally finished. |
b754a26 to
c5aa7de
Compare
|
@NotMyWing This PR requires AE2FC's #191 PR to be merged because it uses content from that PR. Without merging, AE2FC installation will crash. |
resolved #70
resolved #67