Skip to content

[Deepseek V4] Add caching support and verify decoding#4176

Open
Rohan-Bierneni wants to merge 1 commit into
mainfrom
rbierneni-v4-decoding
Open

[Deepseek V4] Add caching support and verify decoding#4176
Rohan-Bierneni wants to merge 1 commit into
mainfrom
rbierneni-v4-decoding

Conversation

@Rohan-Bierneni

Copy link
Copy Markdown
Collaborator

Description

PR add caching support to attention_compressed.py and verifies v4 has decoding support with the maxengine/jetstream backend

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456

Tests

Decode.py should pass (In progress)

cmd:
output:

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.45455% with 57 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/layers/attention_compressed.py 65.45% 39 Missing and 18 partials ⚠️

📢 Thoughts on this report? Let us know!

Integrate v4 attention file with maxengine

Write unit test for testing caching in compressed_attention and make fixes to get test passing
@Rohan-Bierneni Rohan-Bierneni force-pushed the rbierneni-v4-decoding branch from 250c9ce to 4dc04bc Compare June 18, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant